From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47701)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VWY5D-0000Wq-3Y
	for qemu-devel@nongnu.org; Wed, 16 Oct 2013 16:52:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VWY58-0006h2-8O
	for qemu-devel@nongnu.org; Wed, 16 Oct 2013 16:52:43 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <525EFC90.5010302@twiddle.net>
Date: Wed, 16 Oct 2013 13:52:32 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <525EA08D.7000004@gmail.com>
In-Reply-To: <525EA08D.7000004@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fix float64_to_uint64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 10/16/2013 07:19 AM, Tom Musta wrote:
> The comment preceding the float64_to_uint64 routine suggests that
> the implementation is broken.  And this is, indeed, the case.
> 
> This patch properly implements the conversion of a 64-bit floating
> point number to an unsigned, 64 bit integer.
> 
> Note that the patch does not pass scripts/checkpatch.pl because it
> maintains the coding style of fpu/softfloat.c.
> ---
>  fpu/softfloat.c |   92 ++++++++++++++++++++++++++++++++++++++++++++++++++----
>  1 files changed, 85 insertions(+), 7 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~