From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
gleb@redhat.com, marcel.a@redhat.com,
qemu-devel <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support
Date: Wed, 16 Oct 2013 23:26:11 +0200 [thread overview]
Message-ID: <525F0473.6060408@redhat.com> (raw)
In-Reply-To: <20131016183732.GA8157@redhat.com>
Il 16/10/2013 20:37, Michael S. Tsirkin ha scritto:
> Gleb, Paolo, what do you think? OK to merge kvm unit test
> into qemu? It depends on qemu anyway, in-tree will make it easier.
> Maybe someone's looking at this already?
I think merging KVM unit tests doesn't make much sense because, with
some small exceptions, it is mostly a test or a benchmark for KVM. What
may make sense is to have a quick way to run autotest on a QEMU tree,
with a subset of testcases that doesn't take too much time (let's say <4
hours) and is more or less guaranteed to pass. KVM unit tests are run
by autotest, that should be enough.
I agree with Anthony that device model code should be tested by qtest.
I'm not sure this extends to firmware interfaces, though, for two reasons:
(1) any testcase you could have written would have likely not shown the
kind of problem that Igor and Gerd found in your previous versions.
Black box unit testing can only do so much for something as complex as a
DSDT, while black box integration testing works well.
(2) IMO qtest's main advantage is that, at least in principle, the same
testcases could run on all the rarely-used almost-unmaintained targets
(the endianness-test already does that for example). This does not
apply to most firmware interfaces, though.
By the way, this advantage of qtest is also being mostly negated by the
immaturity (or sheer absence) of infrastructure.
Looking at bugs that were reported, at least these two from Igor are
probably best handled with integration tests (like autotest or Anthony's
qemu-test):
* WS2008R2x64 BSODs with ACPI error on boot when 64bit PCI hole is
present, but it boots fine with upstream QEMU
* hotadd CPU to guest, reboot guest, only initial CPUs are visible to guest
qtest could at best host some sanity checks on the ACPI tables, which
would catch the MCFG problems that Gerd reported on v5.
Gerd also reported some segfaults, not sure how they escaped mst's
testing so I cannot judge what kind of testing could have exposed them
preemptively.
Paolo
next prev parent reply other threads:[~2013-10-16 21:26 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 14:57 [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements Michael S. Tsirkin
2013-10-14 14:57 ` Paolo Bonzini
2013-10-14 15:12 ` Michael S. Tsirkin
2013-10-14 15:21 ` Paolo Bonzini
2013-10-14 14:57 ` [Qemu-devel] [PULL 01/43] memory: Change MemoryRegion priorities from unsigned to signed Michael S. Tsirkin
2013-10-14 14:57 ` [Qemu-devel] [PULL 02/43] docs/memory: Explictly state that MemoryRegion priority is signed Michael S. Tsirkin
2013-10-14 14:57 ` [Qemu-devel] [PULL 03/43] hw/pci: partially handle pci master abort Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 04/43] hw/core: Add interface to allocate and free a single IRQ Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 05/43] hw/pci: add pci wrappers for allocating and asserting irqs Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 06/43] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 07/43] hw/vmxnet3: set interrupts using pci irq wrappers Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 08/43] hw/vfio: " Michael S. Tsirkin
2013-10-14 15:46 ` Alex Williamson
2013-10-14 14:58 ` [Qemu-devel] [PULL 09/43] hw: " Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 10/43] hw/pcie: AER and hot-plug events must use device's interrupt Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 11/43] hw/pci: removed irq field from PCIDevice Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 12/43] cleanup object.h: include error.h directly Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 13/43] qom: cleanup struct Error references Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 14/43] qom: add pointer to int property helpers Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 15/43] pci: fix up w64 size calculation helper Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 16/43] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-10-14 14:58 ` [Qemu-devel] [PULL 17/43] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-11-08 0:54 ` Alexander Graf
2013-11-09 17:21 ` Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 18/43] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 19/43] pcie_host: expose address format Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 20/43] q35: use macro for MCFG property name Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 21/43] q35: expose mmcfg size as a property Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 22/43] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 23/43] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 24/43] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 25/43] acpi: ssdt pcihp: updat generated file Michael S. Tsirkin
2013-10-14 22:32 ` Anthony Liguori
2013-10-15 5:24 ` Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 26/43] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 27/43] i386: add bios linker/loader Michael S. Tsirkin
2013-10-14 14:59 ` [Qemu-devel] [PULL 28/43] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 29/43] i386: define pc guest info Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 30/43] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 31/43] piix: APIs for pc guest info Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 32/43] ich9: " Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 33/43] pvpanic: add API to access io port Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 34/43] hpet: add API to find it Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 35/43] acpi: add interface to access user-installed tables Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 36/43] pc: use new api to add builtin tables Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 37/43] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-10-14 15:00 ` [Qemu-devel] [PULL 38/43] ssdt: fix PBLK length Michael S. Tsirkin
2013-10-14 15:01 ` [Qemu-devel] [PULL 39/43] ssdt-proc: update generated file Michael S. Tsirkin
2013-10-14 15:01 ` [Qemu-devel] [PULL 40/43] pci: add pci_for_each_bus_depth_first Michael S. Tsirkin
2013-10-14 15:01 ` [Qemu-devel] [PULL 41/43] pcihp: generalization of piix4 acpi Michael S. Tsirkin
2013-10-14 22:36 ` Anthony Liguori
2013-10-15 5:23 ` Michael S. Tsirkin
2013-10-14 15:01 ` [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support Michael S. Tsirkin
2013-10-15 14:31 ` Paolo Bonzini
2013-10-15 14:35 ` Michael S. Tsirkin
2013-10-15 14:50 ` Paolo Bonzini
2013-10-15 14:54 ` Michael S. Tsirkin
2013-10-15 14:54 ` Paolo Bonzini
2013-10-15 15:07 ` Michael S. Tsirkin
2013-10-15 15:09 ` Paolo Bonzini
2013-10-15 15:16 ` Michael S. Tsirkin
2013-10-15 16:27 ` Anthony Liguori
2013-10-15 20:17 ` Michael S. Tsirkin
2013-10-16 15:03 ` Paolo Bonzini
2013-10-16 16:38 ` Anthony Liguori
2013-10-16 18:18 ` Michael S. Tsirkin
2013-10-16 18:18 ` Anthony Liguori
2013-10-16 18:37 ` Michael S. Tsirkin
2013-10-16 21:26 ` Paolo Bonzini [this message]
2013-10-16 22:03 ` Michael S. Tsirkin
2013-10-16 22:25 ` Paolo Bonzini
2013-10-16 23:52 ` Anthony Liguori
2013-10-17 5:22 ` Michael S. Tsirkin
2013-10-17 5:32 ` Michael S. Tsirkin
2013-10-17 5:48 ` Gleb Natapov
2013-10-17 5:34 ` Michael S. Tsirkin
2013-10-17 11:06 ` Paolo Bonzini
2013-10-17 8:18 ` Gerd Hoffmann
2013-12-10 11:15 ` Igor Mammedov
2013-10-14 15:01 ` [Qemu-devel] [PULL 43/43] acpi-build: enable hotplug for PCI bridges Michael S. Tsirkin
2013-10-14 22:42 ` [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements Anthony Liguori
2013-10-15 5:28 ` Michael S. Tsirkin
2013-10-15 13:51 ` Anthony Liguori
2013-10-15 14:01 ` Paolo Bonzini
2013-10-15 14:17 ` Anthony Liguori
2013-10-15 14:24 ` Michael S. Tsirkin
2013-10-15 14:09 ` Igor Mammedov
2013-10-15 14:20 ` Michael S. Tsirkin
2013-10-15 14:21 ` Anthony Liguori
2013-10-15 14:30 ` Michael S. Tsirkin
2013-10-15 14:37 ` Michael S. Tsirkin
2013-10-15 14:51 ` Michael S. Tsirkin
2013-10-15 15:27 ` Igor Mammedov
2013-10-15 15:37 ` Michael S. Tsirkin
2013-10-15 5:33 ` Michael S. Tsirkin
2013-10-15 11:53 ` Igor Mammedov
2013-10-15 13:43 ` Gerd Hoffmann
2013-10-15 13:53 ` Anthony Liguori
2013-10-15 14:21 ` Michael S. Tsirkin
2013-10-15 14:14 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525F0473.6060408@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).