From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWjFJ-00018T-Cr for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:48:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWjFB-000203-Q4 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:47:53 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:58526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWjF3-0001uc-RW for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:47:45 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Oct 2013 18:47:21 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 3DF602CE805A for ; Thu, 17 Oct 2013 19:47:19 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9H8eFIJ10289506 for ; Thu, 17 Oct 2013 19:47:07 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9H8YnZV029533 for ; Thu, 17 Oct 2013 19:34:49 +1100 Message-ID: <525FA126.4090302@linux.vnet.ibm.com> Date: Thu, 17 Oct 2013 16:34:46 +0800 From: mike MIME-Version: 1.0 References: <1381979761-2180-1-git-send-email-qiudayu@linux.vnet.ibm.com> <20131017081401.GB10774@stefanha-thinkpad.redhat.com> In-Reply-To: <20131017081401.GB10774@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, benoit@irqsave.net, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com On 10/17/2013 04:14 PM, Stefan Hajnoczi wrote: > On Wed, Oct 16, 2013 at 11:16:01PM -0400, Mike Qiu wrote: >> Change to v1: >> remove '[not inserted]' line instead of adding '\n' >> >> Output of 'info block' >> >> scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) >> [not inserted] >> scsi0-cd2: [not inserted] >> Removable device: not locked, tray closed >> >> floppy0: [not inserted] >> Removable device: not locked, tray closed >> >> sd0: [not inserted] >> Removable device: not locked, tray closed >> >> There will be no additional lines between scsi0-hd0 and >> scsi0-cd2. >> >> At the same time, scsi0-hd0 already inserted, but still has >> '[not inserted]' flag. This line should be removed. >> >> This patch is to solve this. >> >> Signed-off-by: Mike Qiu >> --- >> hmp.c | 2 -- >> 1 file changed, 2 deletions(-) > The commit message is out-of-date, this patch now drops the bogus "[not > inserted]" output. I fixed up the commit message. > > In the future, please put the patch changelog after the "---" line so > that git am does not include the changelog in the commit description. OK， Got it, thanks for your kindly remind :) Thanks Mike > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block > > Stefan > >