qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: mike <qiudayu@linux.vnet.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: benoit@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org,
	lcapitulino@redhat.com, stefanha@redhat.com,
	xiawenc@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()
Date: Thu, 17 Oct 2013 16:35:52 +0800	[thread overview]
Message-ID: <525FA168.1070304@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131017081114.GB2942@dhcp-200-207.str.redhat.com>

On 10/17/2013 04:11 PM, Kevin Wolf wrote:
> Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben:
>> Change to v1:
>> 	remove '[not inserted]' line instead of adding '\n'
> Please put such notes for reviewers below the --- line, so that git am
> automatically removes them and they don't end up in the git commit
> message.
OK, thanks for your kindly remind,

Thanks
Mike
>> Output of 'info block'
>>
>> scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
>>   [not inserted]
>> scsi0-cd2: [not inserted]
>>      Removable device: not locked, tray closed
>>
>> floppy0: [not inserted]
>>      Removable device: not locked, tray closed
>>
>> sd0: [not inserted]
>>      Removable device: not locked, tray closed
>>
>> There will be no additional lines between scsi0-hd0 and
>> scsi0-cd2.
>>
>> At the same time, scsi0-hd0 already inserted, but still has
>> '[not inserted]' flag. This line should be removed.
>>
>> This patch is to solve this.
>>
>> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
>
>

  reply	other threads:[~2013-10-17  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17  3:16 [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf() Mike Qiu
2013-10-17  8:11 ` Kevin Wolf
2013-10-17  8:35   ` mike [this message]
2013-10-17  8:14 ` Stefan Hajnoczi
2013-10-17  8:34   ` mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525FA168.1070304@linux.vnet.ibm.com \
    --to=qiudayu@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).