From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWjDD-00006T-KM for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWjD4-0001Kx-MU for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:45:43 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:39610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWjCv-0001Eq-Qn for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:45:34 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Oct 2013 18:45:09 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 5F0842BB0054 for ; Thu, 17 Oct 2013 19:45:06 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9H8eF5T10289506 for ; Thu, 17 Oct 2013 19:44:54 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9H8ZsIU031720 for ; Thu, 17 Oct 2013 19:35:54 +1100 Message-ID: <525FA168.1070304@linux.vnet.ibm.com> Date: Thu, 17 Oct 2013 16:35:52 +0800 From: mike MIME-Version: 1.0 References: <1381979761-2180-1-git-send-email-qiudayu@linux.vnet.ibm.com> <20131017081114.GB2942@dhcp-200-207.str.redhat.com> In-Reply-To: <20131017081114.GB2942@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: benoit@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com On 10/17/2013 04:11 PM, Kevin Wolf wrote: > Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben: >> Change to v1: >> remove '[not inserted]' line instead of adding '\n' > Please put such notes for reviewers below the --- line, so that git am > automatically removes them and they don't end up in the git commit > message. OK, thanks for your kindly remind, Thanks Mike >> Output of 'info block' >> >> scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) >> [not inserted] >> scsi0-cd2: [not inserted] >> Removable device: not locked, tray closed >> >> floppy0: [not inserted] >> Removable device: not locked, tray closed >> >> sd0: [not inserted] >> Removable device: not locked, tray closed >> >> There will be no additional lines between scsi0-hd0 and >> scsi0-cd2. >> >> At the same time, scsi0-hd0 already inserted, but still has >> '[not inserted]' flag. This line should be removed. >> >> This patch is to solve this. >> >> Signed-off-by: Mike Qiu > Reviewed-by: Kevin Wolf > > >