From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2 5/6] util: Provide fallback hwcap and platform for powerpc
Date: Thu, 17 Oct 2013 06:11:53 -0700 [thread overview]
Message-ID: <525FE219.3090907@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_RLdwUf9f0+p+MJ0B3oT47ze8h47s34Yz3obLLDJUt-A@mail.gmail.com>
On 10/17/2013 05:03 AM, Peter Maydell wrote:
> On 10 September 2013 23:07, Richard Henderson <rth@twiddle.net> wrote:
>> Allow host "detection" on non-linux hosts.
>>
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>> util/getauxval.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>> 1 file changed, 54 insertions(+), 2 deletions(-)
>>
>> diff --git a/util/getauxval.c b/util/getauxval.c
>> index 59f53ff..e7f7d63 100644
>> --- a/util/getauxval.c
>> +++ b/util/getauxval.c
>> @@ -60,12 +60,64 @@ void qemu_init_auxval(char **envp)
>>
>> static const char *default_platform(void)
>> {
>> - return NULL;
>> + const char *ret = NULL;
>> +
>> +#ifdef _ARCH_PPC
>> +# if defined(_ARCH_PWR8)
>> + ret = "power8";
>> +# elif defined(_ARCH_PWR7)
>
> All these arch-specific ifdefs seem out of place in a
> generic util/ source file.
Where should they go? I'm tempted to drop this whole default thing...
r~
next prev parent reply other threads:[~2013-10-17 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 22:07 [Qemu-devel] [PATCH v2 0/6] Improve getauxval support Richard Henderson
2013-09-10 22:07 ` [Qemu-devel] [PATCH v2 1/6] osdep: Create qemu_getauxval and qemu_init_auxval Richard Henderson
2013-10-17 11:48 ` Peter Maydell
2013-09-10 22:07 ` [Qemu-devel] [PATCH v2 2/6] tcg-ppc64: Use qemu_getauxval Richard Henderson
2013-10-17 11:49 ` Peter Maydell
2013-09-10 22:07 ` [Qemu-devel] [PATCH v2 3/6] tcg-arm: " Richard Henderson
2013-10-17 11:59 ` Peter Maydell
2013-09-10 22:07 ` [Qemu-devel] [PATCH v2 4/6] tcg-s390: Use qemu_getauxval in query_facilities Richard Henderson
2013-09-10 22:07 ` [Qemu-devel] [PATCH v2 5/6] util: Provide fallback hwcap and platform for powerpc Richard Henderson
2013-10-17 12:03 ` Peter Maydell
2013-10-17 13:11 ` Richard Henderson [this message]
2013-09-10 22:07 ` [Qemu-devel] [PATCH v2 6/6] util: Use qemu_getauxval in linux qemu_cache_utils_init Richard Henderson
2013-10-17 12:05 ` Peter Maydell
2013-09-25 18:15 ` [Qemu-devel] [PATCH v2 0/6] Improve getauxval support Richard Henderson
2013-10-01 21:25 ` Richard Henderson
2013-10-02 1:42 ` Peter Maydell
2013-10-02 15:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525FE219.3090907@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).