From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C6BC2D0DB for ; Thu, 30 Jan 2020 16:39:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F03D020674 for ; Thu, 30 Jan 2020 16:39:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="EHKdgp9w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F03D020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixCqR-0000ZA-6a for qemu-devel@archiver.kernel.org; Thu, 30 Jan 2020 11:39:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49601) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixChw-0005Ls-2H for qemu-devel@nongnu.org; Thu, 30 Jan 2020 11:30:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixChu-0004cX-Ks for qemu-devel@nongnu.org; Thu, 30 Jan 2020 11:30:19 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:49950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixChu-0004bD-B1 for qemu-devel@nongnu.org; Thu, 30 Jan 2020 11:30:18 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00UGSF7d194782; Thu, 30 Jan 2020 16:30:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=oUB5i7LGFHKpTQgigjjZPBJpO1xkpbU2Q2d4TNXGdJQ=; b=EHKdgp9wGvajX2QDBPWpH70QiHjHV/tpdmkuap9zoasc0FDFllV+DJ0iy4qZBo6GOr6Q tLY6zfR5BcVjENwwObJE5t2Pq/lkD1+sZtZK3j8i23WNBewYBCrCimWxcNIQZuv1dk/J hrV71OlTIB/gkxIGnGGyetdgGVxKI0ll1LABB8dz9ZumTKvf+Jk52078iAxBsZzdQ2I7 k8mdqP2dY1DAH66ev+1AedoPBmqftMrM030h0YjAAmzbvK869wQ3rm82cT46AmrE6lnV Szn8V4uTEhM2MtFPz42Q9m+mEbRRWjDaFgIyGokLlhXeJSZnozZzjzRcLdL8dcilg1ku RQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2xrdmqw9uv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Jan 2020 16:30:08 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00UGTgjH094193; Thu, 30 Jan 2020 16:30:07 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2xuemwqhed-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Jan 2020 16:29:59 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00UGSuJe032128; Thu, 30 Jan 2020 16:28:56 GMT Received: from [10.175.206.58] (/10.175.206.58) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 30 Jan 2020 08:28:55 -0800 Subject: Re: [PATCH 2/6] tests/boot_linux_console: add BIOS acceptance test From: Liam Merwick To: Stefano Garzarella References: <1580142994-1836-1-git-send-email-liam.merwick@oracle.com> <1580142994-1836-3-git-send-email-liam.merwick@oracle.com> <20200130112721.vm5u5zv7bifjremw@steredhat> Message-ID: <525a194e-131a-56e2-2870-e8709a214135@oracle.com> Date: Thu, 30 Jan 2020 16:28:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9516 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001300115 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9516 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001300115 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by aserp2120.oracle.com id 00UGSF7d194782 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, slp@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org, wainersm@redhat.com, pbonzini@redhat.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 30/01/2020 15:34, Liam Merwick wrote: > On 30/01/2020 11:27, Stefano Garzarella wrote: >> Hi Liam, >> >> On Mon, Jan 27, 2020 at 04:36:30PM +0000, Liam Merwick wrote: >>> Add tests to use qboot with the 'pc' and 'microvm' machine classes >>> by adding the '-bios' option via self.vm.add_args() before calling >>> do_test_x86_64_machine(). >>> >>> Signed-off-by: Liam Merwick >>> --- >>> =C2=A0 tests/acceptance/boot_linux_console.py | 15 ++++++++++++++- >>> =C2=A0 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/tests/acceptance/boot_linux_console.py=20 >>> b/tests/acceptance/boot_linux_console.py >>> index aa5b07b1c609..8daf6461ffac 100644 >>> --- a/tests/acceptance/boot_linux_console.py >>> +++ b/tests/acceptance/boot_linux_console.py >=20 > ... >=20 >>> +=C2=A0=C2=A0=C2=A0 def test_x86_64_microvm_qboot(self): >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags=3Dmachine:= microvm >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.vm.add_args('-bios',= 'pc-bios/bios-microvm.bin') >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 self.do_test_x86_64_machi= ne() >>> + >> >> Reading the docs/microvm.rst, microvm should use qboot as default, so >> the test_x86_64_microvm() and test_x86_64_microvm_qboot() maybe are th= e >> same (I didn't test them). >=20 > I traced loader_write_rom() and in both cases bios-microvm.bin got > loaded. While there may be a slight benefit in verifying that usage of > an explicit -bios works, I think I'll just drop the unnecessary test > case in patches 2 and 6 in v2. >=20 When making that change to remove the test case from Patch2, it dawned on me that it might be worth testing microvm with a different bios=20 instead... --- a/tests/acceptance/boot_linux_console.py +++ b/tests/acceptance/boot_linux_console.py @@ -87,6 +87,13 @@ class BootLinuxConsole(Test): """ self.do_test_x86_64_machine() + def test_x86_64_microvm_seabios(self): + """ + :avocado: tags=3Dmachine:microvm + """ + self.vm.add_args('-bios', 'pc-bios/bios.bin') + self.do_test_x86_64_machine() + >> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 def test_mips_malta(self): >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 """ >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :avocado: tags= =3Darch:mips >> >> Thanks for doing these tests! >=20 > And thanks for reviewing the series. >=20 > Regards, > Liam >=20