From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7F08D3C90D for ; Wed, 10 Dec 2025 14:13:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vTKvw-0000X5-Dc; Wed, 10 Dec 2025 09:12:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTKvu-0000Wh-0E for qemu-devel@nongnu.org; Wed, 10 Dec 2025 09:12:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vTKvq-0001A2-3R for qemu-devel@nongnu.org; Wed, 10 Dec 2025 09:12:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765375960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bD7VQpcxs+TbhrRDYM1QFHTonaft9S0aXPWes5+S7Xg=; b=f353kzkxNFyYHdRrmqNXtmG1ehFTqSXEil5w9hpX7AL+UoP15hNnm3Dc9C8/JH1QCFvgf4 FlvYes2iQ//hRZ+dG9kEsEmeHvUrrRFt5qwXt/eeO3GDGEJNOclnvTiOPim3ys+XcB0RwB c3+HLc5oFtSMcgs5MTSTc4bfiIBV2E0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-FkcTBLrHN3eOYFAehAx_Aw-1; Wed, 10 Dec 2025 09:12:39 -0500 X-MC-Unique: FkcTBLrHN3eOYFAehAx_Aw-1 X-Mimecast-MFC-AGG-ID: FkcTBLrHN3eOYFAehAx_Aw_1765375958 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47777158a85so82140305e9.3 for ; Wed, 10 Dec 2025 06:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765375957; x=1765980757; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=bD7VQpcxs+TbhrRDYM1QFHTonaft9S0aXPWes5+S7Xg=; b=Qp1iLFnMKvOZ5BFij0g1rVUNnqrx6L2QvebMfotZ14lOr8+OAIULDsIje5CQbvP8H+ dxBNrLIqhbvZpakJzF+JrVvVhx3zseUD7aDsRicd3x8rIeDdbUovSSKHsdPow61LWq9F qWHlOWpdB7HbPv/Ak9i0u+tH/AOgXN0YfLlpcjuD4x6bc4g26aMwsx7PGudJnzcWO5CW qRxmZb1cpiMf5ywaYa8U351xBfmKy8o52/vAm/sFNkLRNTV9GXlzTkteBUrVi0aqQh9V D330aKm5VzS1p8trUK68lD54CtV2BpmjxMCe6ExIaqKfN1fdIfRQMfWVvzyDVWswrlIr RDSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765375957; x=1765980757; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bD7VQpcxs+TbhrRDYM1QFHTonaft9S0aXPWes5+S7Xg=; b=S5ox9jPANMG4snpyep26AswDAP6dLITkJBJoBnJjFJyAJCfoeG3oqcJ6d3ykKQ3fLk SWERKu3AK7Exu01x7hynSiewdqK+8T7OQeDR4yLvm00XZgCLXVo2gRcvyUJfVND+jyWY jTpH2EinhUmIMh5Tcbh/fI9V9+hbySNa7/G5aDO7graglzFpaQIAAQJa+kphAfr7YJ59 iRzX1P2t6R1bE1zhvPArJTvmGqeK4m/oq1EZtzrjdbskQKfAdmASNYubvZKTPH0hDG5C ELd4SwPs5XZCaVsMBZUKTMRtV5DusZv/TcxD+RJ3H27OIhupYqmqkru7sJxPVbxaWpH+ dGOA== X-Gm-Message-State: AOJu0YybNYAhSV03gnpY8lei6gCy6SXkiVcJcgoiztt0UlbUcH7YN95E H4P63g/F30lLPxRRppOTFx3S9nA7WB7pAWmxGhXUGIe9JcV7iKoOKsQ8NvGmyiS3MjpzfoT4sir w0fYsmlZ8hq13kF4+f5rb+5ish1+6JJ2QwoMY3a9uNNItun0uvCrVFbPoYzTs6iDp X-Gm-Gg: ASbGncsb9wsXM5UQ7d1nFJisLSp23PXGZWu21MxQtQz0mZ+3MDIMW5SUBkpnplv7e8A 99YhI4dgJCf5vAT0mVARkdIlHsJI0cemiu3CSxBKmGuyMVfFfQVb99tI28elQRsrTbNUW6zI+1V Ex87pPx/M/pWvA0lBK1qHQzB2NtKYDHJmDa03pXEnr1DVSKRX+vkFSV8nHq3KcYyU/zi4e4TsE0 XfS6x1tCDsEka4e8n8/5aTLX+CqIYFfLUKaNE4UTOajeqh/TPzsjirSjZQt4QXcq7DnkuGEbfFS G9n+lolpzAvidg4Czt1nOwsYiLd+dbCz7W6F/dNOjvG9NpCACIeg0mY5H5BWHYaEQ1poKFoboyj Qif9gnpqBmBY8fn0nxqysKUStGypat0cth34L8pXdBePdLIQ9c+He2xXPpUZX1B/Egs+ok3xZtJ VkkdFR5zy9XEXzPWs= X-Received: by 2002:a05:600c:5254:b0:46e:37fe:f0e6 with SMTP id 5b1f17b1804b1-47a8379c0fbmr27781515e9.30.1765375957474; Wed, 10 Dec 2025 06:12:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhiVwTChDd/3XDYLxr+06OGfpaN/2udr1vtiMW39shQvpLPhuHFYoR62rkwb0oFfxPP7jr6Q== X-Received: by 2002:a05:600c:5254:b0:46e:37fe:f0e6 with SMTP id 5b1f17b1804b1-47a8379c0fbmr27781255e9.30.1765375957044; Wed, 10 Dec 2025 06:12:37 -0800 (PST) Received: from [192.168.10.81] ([151.95.145.106]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-47a7d35713asm43967835e9.1.2025.12.10.06.12.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 06:12:36 -0800 (PST) Message-ID: <525d2198-5d6f-43a0-88cd-78eae0042d27@redhat.com> Date: Wed, 10 Dec 2025 15:12:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/19] rust: QObject and QAPI bindings To: Markus Armbruster Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com, qemu-rust@nongnu.org References: <20251010151006.791038-1-pbonzini@redhat.com> <87tsy52ftl.fsf@pond.sub.org> <87zf7s5h3k.fsf@pond.sub.org> Content-Language: en-US From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <87zf7s5h3k.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/9/25 07:01, Markus Armbruster wrote: > Markus Armbruster writes: > >> I applied, ran make, and it didn't create qapi-types.rs and >> test-qapi-types.rs for me. What am I missing? > > Looks like I have to run with -B qapi.backend.QAPIRsBackend. > > -B is meant for out-of-tree backends. Commit dde279925c9 explains: > > qapi: pluggable backend code generators > > The 'qapi.backend.QAPIBackend' class defines an API contract for code > generators. The current generator is put into a new class > 'qapi.backend.QAPICBackend' and made to be the default impl. > > A custom generator can be requested using the '-k' arg which takes a > fully qualified python class name > > qapi-gen.py -B the.python.module.QAPIMyBackend > > This allows out of tree code to use the QAPI generator infrastructure > to create new language bindings for QAPI schemas. This has the caveat > that the QAPI generator APIs are not guaranteed stable, so consumers > of this feature may have to update their code to be compatible with > future QEMU releases. > > Using it for the in-tree Rust backend is fine for a prototype. > Mentioning it in a commit message or the cover letter would've saved me > some digging. Well, it wasn't intentional - right now it does this: test_qapi_rs_files = custom_target('QAPI Rust', output: 'test-qapi-types.rs', input: [ files(meson.project_source_root() + '/tests/qapi-schema/qapi-schema-test.json') ], command: [ qapi_gen, '-o', meson.current_build_dir(), '-b', '@INPUT0@', '-B', 'qapi.backend.QAPIRsBackend', '-p', 'test-' ], depend_files: [ qapi_inputs, qapi_gen_depends ]) so "make rust/tests/test-qapi-types.rs" will work, and so will "make" if you have --enable-rust. Let us know what you'd prefer and we'll switch. Alternatively, retconning -B's meaning so that it applies to Rust will work too. :) Paolo