From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWrqJ-0000x2-HN for qemu-devel@nongnu.org; Thu, 17 Oct 2013 13:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWrqB-0005Uj-0f for qemu-devel@nongnu.org; Thu, 17 Oct 2013 13:58:39 -0400 Message-ID: <52602530.10800@gmail.com> Date: Thu, 17 Oct 2013 12:58:08 -0500 From: Tom Musta MIME-Version: 1.0 References: <525EA08D.7000004@gmail.com> <525F00C1.5050002@gmail.com> <9D42EDA5-1E37-4E8E-B38C-643CC76D49FB@suse.de> <526010E8.8090207@weilnetz.de> In-Reply-To: <526010E8.8090207@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Peter Maydell , Richard Henderson , "qemu-ppc@nongnu.org" , Alexander Graf , QEMU Developers > On 10/17/2013 11:31 AM, Stefan Weil wrote: >> Am 17.10.2013 11:40, schrieb Alexander Graf: >> Missing a SoB line. >> >> >> Alex > > There is already a mix of coding styles in fpu/softfloat.c, and your > patch adds large regions of new code. > Therefore I expect that such contributions should respect the QEMU > coding style. > > The situation is different if only single lines in some function are > replaced or added. > > Stefan > OK .... I will rework the patch to use QEMU style. And will add the sob.