From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35826)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6Tq-0001Ww-0F
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:36:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6Tj-0007E0-AE
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:36:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6Tj-0007Dh-2A
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:36:19 -0400
Message-ID: <5261010A.80400@redhat.com>
Date: Fri, 18 Oct 2013 11:36:10 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382058681-14957-3-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1382058681-14957-3-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in
	block.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

Il 18/10/2013 03:11, Wenchao Xia ha scritto:
> block_int.h already included it.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  block.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/block.c b/block.c
> index 2c15e5d..e92a556 100644
> --- a/block.c
> +++ b/block.c
> @@ -24,7 +24,6 @@
>  #include "config-host.h"
>  #include "qemu-common.h"
>  #include "trace.h"
> -#include "monitor/monitor.h"
>  #include "block/block_int.h"
>  #include "block/blockjob.h"
>  #include "qemu/module.h"
> 

Does this cause problems?  block.c uses monitor_protocol_event, so it's
good to include the file directly instead of relying on other header files.

Paolo