From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6c5-00076Q-5h
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:45:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6bz-0001MB-6b
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:44:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6680)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VX6by-0001Ly-PD
	for qemu-devel@nongnu.org; Fri, 18 Oct 2013 05:44:51 -0400
Message-ID: <5261030B.3040804@redhat.com>
Date: Fri, 18 Oct 2013 11:44:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382058681-14957-10-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1382058681-14957-10-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/13] error: print progname with
	error_vprintf()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

Il 18/10/2013 03:11, Wenchao Xia ha scritto:
> This remove additional code path about where to print the error,
> error_vprintf() is only the controller now, making future change
> easier.
> 
> The logic is not changed since when cur_mon = NULL, error_vprintf()
> will still print to stderr.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  util/qemu-error.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index d1e858a..c29fcbd 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -151,6 +151,15 @@ const char *error_get_progname(void)
>      return progname;
>  }
>  
> +static void error_print_progname(const char *fmt, ...)
> +{
> +    va_list ap;
> +
> +    va_start(ap, fmt);
> +    error_vprintf(fmt, ap);
> +    va_end(ap);
> +}
> +
>  /*
>   * Print current location to current monitor if we have one, else to stderr.
>   */
> @@ -161,7 +170,7 @@ static void error_print_loc(void)
>      const char *const *argp;
>  
>      if (!cur_mon && progname) {
> -        fprintf(stderr, "%s: ", progname);
> +        error_print_progname("%s: ", progname);
>      }
>      switch (cur_loc->kind) {
>      case LOC_CMDLINE:
> 

I agree that using fprintf looks odd, but why not use error_printf directly?

Paolo