From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define
Date: Fri, 18 Oct 2013 06:38:02 -0600 [thread overview]
Message-ID: <52612BAA.4040307@redhat.com> (raw)
In-Reply-To: <52610126.6040106@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On 10/18/2013 03:36 AM, Paolo Bonzini wrote:
> Il 18/10/2013 03:11, Wenchao Xia ha scritto:
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>> include/monitor/monitor.h | 38 +-------------------------
>> include/qapi/qmp/qevent.h | 66 +++++++++++++++++++++++++++++++++++++++++++++
>> include/qapi/qmp/types.h | 1 +
>> 3 files changed, 68 insertions(+), 37 deletions(-)
>> create mode 100644 include/qapi/qmp/qevent.h
>>
>
> Please move it qemu-schema.json instead.
qapi-schema.json, but yes, I agree that declaring it as a qapi enum and
letting the code generator create the constants, rather than moving the
hand-maintained constants into a new header, is smarter.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-18 12:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 1:11 [Qemu-devel] [PATCH 00/13] trivial patches for event, error and monitor Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 01/13] block: use type MonitorEvent directly Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c Wenchao Xia
2013-10-18 9:36 ` Paolo Bonzini
2013-10-21 2:43 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define Wenchao Xia
2013-10-18 9:36 ` Paolo Bonzini
2013-10-18 12:38 ` Eric Blake [this message]
2013-10-21 2:44 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 04/13] qapi: rename MonitorEvent to QEvent Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 05/13] error: define struct Error in only one place Wenchao Xia
2013-10-18 9:37 ` Paolo Bonzini
2013-10-18 11:22 ` Markus Armbruster
2013-10-21 2:46 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp() Wenchao Xia
2013-10-18 9:39 ` Paolo Bonzini
2013-10-18 11:29 ` Markus Armbruster
2013-10-18 1:11 ` [Qemu-devel] [PATCH 07/13] error: make error_print_loc() static Wenchao Xia
2013-10-18 12:39 ` Eric Blake
2013-10-18 1:11 ` [Qemu-devel] [PATCH 08/13] error: don't set sep when print progname Wenchao Xia
2013-10-18 9:43 ` Paolo Bonzini
2013-10-18 11:40 ` Markus Armbruster
2013-10-21 3:31 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 09/13] error: print progname with error_vprintf() Wenchao Xia
2013-10-18 9:44 ` Paolo Bonzini
2013-10-21 3:33 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 10/13] qerror: deref once in qerror_report() Wenchao Xia
2013-10-18 9:46 ` Paolo Bonzini
2013-10-21 3:35 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 11/13] qerror: folder qerror emit logic Wenchao Xia
2013-10-18 9:49 ` Paolo Bonzini
2013-10-18 1:11 ` [Qemu-devel] [PATCH 12/13] monitor: hide *cur_mon in monitor_get_fd() Wenchao Xia
2013-10-18 9:51 ` Paolo Bonzini
2013-10-21 3:36 ` Wenchao Xia
2013-10-18 1:11 ` [Qemu-devel] [PATCH 13/13] stubs: do not call monitor_printf() Wenchao Xia
2013-10-18 9:52 ` Paolo Bonzini
2013-10-21 6:04 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52612BAA.4040307@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).