From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX9Jl-0004I8-HB for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VX9Jg-0001HG-FU for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:38:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX9Jg-0001HC-64 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:38:08 -0400 Message-ID: <52612BAA.4040307@redhat.com> Date: Fri, 18 Oct 2013 06:38:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382058681-14957-4-git-send-email-xiawenc@linux.vnet.ibm.com> <52610126.6040106@redhat.com> In-Reply-To: <52610126.6040106@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="POh8lkb3njhJLkMTuglcnqiJ8oFx41clb" Subject: Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --POh8lkb3njhJLkMTuglcnqiJ8oFx41clb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/18/2013 03:36 AM, Paolo Bonzini wrote: > Il 18/10/2013 03:11, Wenchao Xia ha scritto: >> Signed-off-by: Wenchao Xia >> --- >> include/monitor/monitor.h | 38 +------------------------- >> include/qapi/qmp/qevent.h | 66 ++++++++++++++++++++++++++++++++++++= +++++++++ >> include/qapi/qmp/types.h | 1 + >> 3 files changed, 68 insertions(+), 37 deletions(-) >> create mode 100644 include/qapi/qmp/qevent.h >> >=20 > Please move it qemu-schema.json instead. qapi-schema.json, but yes, I agree that declaring it as a qapi enum and letting the code generator create the constants, rather than moving the hand-maintained constants into a new header, is smarter. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --POh8lkb3njhJLkMTuglcnqiJ8oFx41clb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSYSuqAAoJEKeha0olJ0NqWWwH/RO0+XD5CkYmzjUSj+4zvSBj BkvlxxRCyS7tzZaX6MrIAb2fMd9PSZcgDJzuYJRNZYjaw9H/02KKkqAe5uZZ+v2s wIQUuP61nxyoCInQ87Fz8K0TpAH6uF7bcIN+87hAjJWPkav3mWKt8/9ROCtN+aKW sU85xGKsnmiiB7Vd0QPO3Ho2Opdm60ofB6AfbzgQIcuIcaq502wEP9xQZ7SbBiX6 iEPKf/FqD10JBq6BtXXJMI+AHMaQtO9ZsF8DDs7WYnf0JBtXHVwPU4sWSsmcZRLQ c51UIE67xJfDgBX7q2PKWqbtbl3kARsZ2PTfbIQ3iovSQ10hQWBxUQzwwT/Au6U= =82Li -----END PGP SIGNATURE----- --POh8lkb3njhJLkMTuglcnqiJ8oFx41clb--