From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, stefanha@redhat.com,
anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks
Date: Fri, 18 Oct 2013 15:50:05 +0200 [thread overview]
Message-ID: <52613C8D.5060708@redhat.com> (raw)
In-Reply-To: <52613709.6040604@kamp.de>
Il 18/10/2013 15:26, Peter Lieven ha scritto:
>>
>>
>> - bdrv_discard_zeroes for bdrv_has_discard_write_zeroes
> This would conform to the linux ioctl BLKDISCARDZEROES.
> However, we need the write_zeroes operation for a guarantee
> that zeroes are return.
Yes. I'm fine with the current names actually, just thinking loudly.
>> - bdrv_unallocated_blocks_are_zero for bdrv_has_discard_zeroes
>>
>> But I'm not sure why we have different BlockDriver APIs. I'd rather put
>> the new flags in BlockDriverInfo, and make the new functions simple
>> wrappers around bdrv_get_info. I think I proposed that before, maybe I
>> wasn't clear or I was misunderstood.
> I think Kevin wanted to have special functions for this.
Yes, but I think he referred to block.c functions not BlockDriver functions.
Paolo
next prev parent reply other threads:[~2013-10-18 13:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 11:57 [Qemu-devel] [PATCHv4 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 05/17] block/raw: add " Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 06/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 07/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 08/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 09/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 11/17] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 12/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 13/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-18 12:38 ` Stefan Hajnoczi
2013-10-18 12:49 ` Paolo Bonzini
2013-10-18 13:24 ` Stefan Hajnoczi
2013-10-18 13:52 ` Peter Lieven
2013-10-18 13:58 ` Paolo Bonzini
2013-10-18 13:26 ` Peter Lieven
2013-10-18 13:50 ` Paolo Bonzini [this message]
2013-10-18 19:10 ` Peter Lieven
2013-10-30 8:28 ` Stefan Hajnoczi
2013-10-30 21:22 ` Peter Lieven
2013-10-18 13:20 ` Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 15/17] qemu-img: add support for fully allocated images Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-18 12:26 ` Stefan Hajnoczi
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 17/17] block/raw: copy BlockLimits on raw_open Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52613C8D.5060708@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).