From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59572)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VY5UT-0008GX-0j
	for qemu-devel@nongnu.org; Sun, 20 Oct 2013 22:45:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VY5UH-00015n-NC
	for qemu-devel@nongnu.org; Sun, 20 Oct 2013 22:45:08 -0400
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:52304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VY5UG-00015g-VK
	for qemu-devel@nongnu.org; Sun, 20 Oct 2013 22:44:57 -0400
Received: from /spool/local
	by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Mon, 21 Oct 2013 12:44:54 +1000
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21])
	by d23dlp01.au.ibm.com (Postfix) with ESMTP id 6DC4A2CE8053
	for <qemu-devel@nongnu.org>; Mon, 21 Oct 2013 13:44:51 +1100 (EST)
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r9L2idKH53739538
	for <qemu-devel@nongnu.org>; Mon, 21 Oct 2013 13:44:39 +1100
Received: from d23av04.au.ibm.com (localhost [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	r9L2ioBG023454
	for <qemu-devel@nongnu.org>; Mon, 21 Oct 2013 13:44:50 +1100
Message-ID: <52649522.4020206@linux.vnet.ibm.com>
Date: Mon, 21 Oct 2013 10:44:50 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382058681-14957-4-git-send-email-xiawenc@linux.vnet.ibm.com>
	<52610126.6040106@redhat.com> <52612BAA.4040307@redhat.com>
In-Reply-To: <52612BAA.4040307@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

于 2013/10/18 20:38, Eric Blake 写道:
> On 10/18/2013 03:36 AM, Paolo Bonzini wrote:
>> Il 18/10/2013 03:11, Wenchao Xia ha scritto:
>>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>>> ---
>>>   include/monitor/monitor.h |   38 +-------------------------
>>>   include/qapi/qmp/qevent.h |   66 +++++++++++++++++++++++++++++++++++++++++++++
>>>   include/qapi/qmp/types.h  |    1 +
>>>   3 files changed, 68 insertions(+), 37 deletions(-)
>>>   create mode 100644 include/qapi/qmp/qevent.h
>> Please move it qemu-schema.json instead.
> qapi-schema.json, but yes, I agree that declaring it as a qapi enum and
> letting the code generator create the constants, rather than moving the
> hand-maintained constants into a new header, is smarter.
>
    I will try use qapi-schema.json in next version.