From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY8lD-0002Jo-GA for qemu-devel@nongnu.org; Mon, 21 Oct 2013 02:14:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VY8l4-0003FF-Ha for qemu-devel@nongnu.org; Mon, 21 Oct 2013 02:14:39 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:44312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VY8l3-0003F4-SG for qemu-devel@nongnu.org; Mon, 21 Oct 2013 02:14:30 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Oct 2013 16:04:15 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 65F402CE8052 for ; Mon, 21 Oct 2013 17:04:13 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9L63uBt4260120 for ; Mon, 21 Oct 2013 17:04:01 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9L647fL007437 for ; Mon, 21 Oct 2013 17:04:07 +1100 Message-ID: <5264C3D7.6010404@linux.vnet.ibm.com> Date: Mon, 21 Oct 2013 14:04:07 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1382058681-14957-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382058681-14957-14-git-send-email-xiawenc@linux.vnet.ibm.com> <526104D1.8050100@redhat.com> In-Reply-To: <526104D1.8050100@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 13/13] stubs: do not call monitor_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com 于 2013/10/18 17:52, Paolo Bonzini 写道: > Il 18/10/2013 03:11, Wenchao Xia ha scritto: >> stubs/pci-drive-host-add.o is packaged together with /stubs/mon-printf.o >> so it would not work normal, remove it. >> >> Signed-off-by: Wenchao Xia >> --- >> stubs/pci-drive-hot-add.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/stubs/pci-drive-hot-add.c b/stubs/pci-drive-hot-add.c >> index 1d98145..af4612f 100644 >> --- a/stubs/pci-drive-hot-add.c >> +++ b/stubs/pci-drive-hot-add.c >> @@ -5,6 +5,5 @@ >> int pci_drive_hot_add(Monitor *mon, const QDict *qdict, DriveInfo *dinfo) >> { >> /* On non-x86 we don't do PCI hotplug */ >> - monitor_printf(mon, "Can't hot-add drive to type %d\n", dinfo->type); >> return -1; >> } >> > This is wrong; stubs are independent, that's why each of them is in its > own C file. > > When linking a version of QEMU that does not have pci_drive_hot_add, > this function will call the monitor_printf from QEMU. > > Paolo > I see, will drop it.