qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: zhanghao1 <zhanghao1@kylinos.cn>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com
Subject: Re: [PATCH v2] virtio: add a new vcpu watchdog
Date: Wed, 5 Jul 2023 13:48:37 +0200	[thread overview]
Message-ID: <5264c37a-cff5-6f39-02fb-625f86f4b696@linaro.org> (raw)
In-Reply-To: <20230705081813.411526-1-zhanghao1@kylinos.cn>

Hi,

On 5/7/23 10:18, zhanghao1 wrote:
> Each vcpu creates a corresponding timer task. The watchdog
> is driven by a timer according to a certain period. Each time
> the timer expires, the counter is decremented. When the counter
> is "0", the watchdog considers the vcpu to be stalling and resets
> the VM. To avoid watchdog expiration, the guest kernel driver
> needs to periodically send a pet event to update the counter.
> 
> Signed-off-by: zhanghao1 <zhanghao1@kylinos.cn>
> ---
> v2:
>   - change the function name and remove the redundant word 'stall'
>   - add trace-events to replace DPRINTF and qemu_log
>   - call 'watchdog_perform_action()' to reset vm
>   - update g_new0 to replace malloc
>   - update only use '.generic_name'
>   - update the bool variable 'is_initialized' to uint32_t
> 
> v1: https://lore.kernel.org/qemu-devel/20230615061302.301754-1-zhanghao1@kylinos.cn/
> 
>   hw/virtio/Kconfig                        |   5 +
>   hw/virtio/meson.build                    |   2 +
>   hw/virtio/trace-events                   |   6 +
>   hw/virtio/virtio-vcpu-watchdog-pci.c     |  86 +++++++++
>   hw/virtio/virtio-vcpu-watchdog.c         | 226 +++++++++++++++++++++++
>   include/hw/virtio/virtio-vcpu-watchdog.h |  37 ++++
>   6 files changed, 362 insertions(+)
>   create mode 100644 hw/virtio/virtio-vcpu-watchdog-pci.c
>   create mode 100644 hw/virtio/virtio-vcpu-watchdog.c
>   create mode 100644 include/hw/virtio/virtio-vcpu-watchdog.h

Applying: virtio: add a new vcpu watchdog
.git/rebase-apply/patch:258: trailing whitespace.

error: patch failed: hw/virtio/meson.build:33
error: hw/virtio/meson.build: patch does not apply
Patch failed at 0001 virtio: add a new vcpu watchdog

On what commit/branch/tree is your patch based?

Thanks,

Phil.


  reply	other threads:[~2023-07-05 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05  8:18 [PATCH v2] virtio: add a new vcpu watchdog zhanghao1
2023-07-05 11:48 ` Philippe Mathieu-Daudé [this message]
2023-07-05 13:42 ` Alex Bennée
2023-07-05 16:35   ` Trilok Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5264c37a-cff5-6f39-02fb-625f86f4b696@linaro.org \
    --to=philmd@linaro.org \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhanghao1@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).