From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohamad.gebai@polymtl.ca>) id 1VYM1x-0001z2-VH
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:24:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mohamad.gebai@polymtl.ca>) id 1VYM1s-0003dG-8u
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:24:49 -0400
Received: from smtp.polymtl.ca ([132.207.4.11]:37199)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohamad.gebai@polymtl.ca>) id 1VYM1s-0003bp-4g
	for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:24:44 -0400
Message-ID: <52658D7E.4010609@polymtl.ca>
Date: Mon, 21 Oct 2013 16:24:30 -0400
From: Mohamad Gebai <mohamad.gebai@polymtl.ca>
MIME-Version: 1.0
References: <1382078393-11195-1-git-send-email-mohamad.gebai@polymtl.ca>
	<1382078393-11195-2-git-send-email-mohamad.gebai@polymtl.ca>
	<20131018140528.GB22532@stefanha-thinkpad.redhat.com>
In-Reply-To: <20131018140528.GB22532@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 1/5] Fix configure script for LTTng 2.x
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, Mohamad Gebai <mohamad.gebai@gmail.com>

On 13-10-18 10:05 AM, Stefan Hajnoczi wrote:
> On Fri, Oct 18, 2013 at 02:39:49AM -0400, Mohamad Gebai wrote:
>> Signed-off-by: Mohamad Gebai <mohamad.gebai@polymtl.ca>
>> ---
>>   configure |    9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 23dbaaf..627054c 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3287,15 +3287,14 @@ fi
>>   # For 'ust' backend, test if ust headers are present
>>   if test "$trace_backend" = "ust"; then
>>     cat > $TMPC << EOF
>> -#include <ust/tracepoint.h>
>> -#include <ust/marker.h>
>> +#include <lttng/tracepoint.h>
>>   int main(void) { return 0; }
>>   EOF
>>     if compile_prog "" "" ; then
>> -    LIBS="-lust -lurcu-bp $LIBS"
>> -    libs_qga="-lust -lurcu-bp $libs_qga"
>> +    LIBS="-llttng-ust -lurcu-bp -ldl $LIBS"
>> +    libs_qga="-llttng-ust -lurcu-bp -ldl $libs_qga"
> Please switch to pkg-config instead of hardcoding particular flags.  I
> checked that Fedora and Debian ship the pkg-config file.
Unfortunately, some missing files in the Ubuntu package make it 
impossible to use pkg-config for versions of Ubuntu older than 13.10 
(like Ubuntu 12.04 which is a LTS). Would you be okay with these flags?