From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMIM-0007y3-HP for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:41:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYMIH-0000d3-M0 for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:41:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMIH-0000cx-DJ for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:41:41 -0400 Message-ID: <5265917D.3000903@redhat.com> Date: Mon, 21 Oct 2013 21:41:33 +0100 From: Eric Blake MIME-Version: 1.0 References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382321765-29052-4-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1382321765-29052-4-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UnukUf8EEOFKRl7mnulNOGdWxtG2kR9rj" Subject: Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UnukUf8EEOFKRl7mnulNOGdWxtG2kR9rj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/21/2013 03:16 AM, Wenchao Xia wrote: > The define will be moved to qapi-schema.json later, so rename the > prefix to match its naming style. Wouldn't it be simpler to fix the code generator to special case QEvent to turn into QEVENT, instead of having to go through this churn? But if we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical: >=20 > Also fixed code style error reported in spice-core.c. >=20 > Signed-off-by: Wenchao Xia > --- > balloon.c | 2 +- > block.c | 4 +- > block/qcow2-refcount.c | 2 +- > blockdev.c | 4 +- > blockjob.c | 5 ++- > cpus.c | 2 +- > hw/acpi/core.c | 2 +- > hw/core/qdev.c | 2 +- > hw/misc/pvpanic.c | 2 +- > hw/net/virtio-net.c | 2 +- > hw/watchdog/watchdog.c | 2 +- > include/monitor/monitor.h | 58 +++++++++++++++++----------------- > monitor.c | 74 ++++++++++++++++++++++---------------= ------- > target-s390x/kvm.c | 2 +- > ui/spice-core.c | 8 ++-- > ui/vnc.c | 6 ++-- > vl.c | 14 ++++---- > 17 files changed, 96 insertions(+), 95 deletions(-) If no one else is as opposed to the Q_EVENT naming as I seem to be, then you can add my reluctant Reviewed-by: Eric Blake in that your change is mechanical and correct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UnukUf8EEOFKRl7mnulNOGdWxtG2kR9rj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSZZF9AAoJEKeha0olJ0Nqb5kIAIk4rbGJ03QLeODapmgfzNFi rnxDH15Z2vX4FHlrmyF1BqCwWKteWllFJHi3vbjGGCcOrdVQslNkO5xj4evgY9jy Pg4EBw6jL7UUkja/L+aMfP9yYQW98FRRzKNidi43sVfHVDZ9Q2Zx4WrkxvCbh5u5 V7K/WHppqE/j4tdPjh5Wz5sNV/ZfvceLwccwioAni+8d4WhlO/6MiEPHkK3Qd85n mlVVlb+vHxhNGDvqjp9Tup1SiR1L6BA0kOh7EQOBLLJVizttvPa9h9MPiUkJXqe8 pPaAMaSJavEONaxB+lIHGMXpZ0IcQ0d38kDKgkIK9bbk/TYGIW1KAxpfuj8zLQA= =Mk1Y -----END PGP SIGNATURE----- --UnukUf8EEOFKRl7mnulNOGdWxtG2kR9rj--