From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMMY-0001Kl-Ns for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:46:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYMMT-0002A1-Rz for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:46:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMMT-00029t-Jb for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:46:01 -0400 Message-ID: <52659282.3050004@redhat.com> Date: Mon, 21 Oct 2013 21:45:54 +0100 From: Eric Blake MIME-Version: 1.0 References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382321765-29052-5-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1382321765-29052-5-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V31eLqGPgMSG1tpBdUAKmb2fLi52LRDg4" Subject: Re: [Qemu-devel] [PATCH 4/6] qapi: move event defines to qapi-schema.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V31eLqGPgMSG1tpBdUAKmb2fLi52LRDg4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/21/2013 03:16 AM, Wenchao Xia wrote: > They are defined with capitals for compatibility, see monitor_event_nam= es > in monitor.c, which was used to set the event strings. Agree; the existing 'query-events' commands returns all-capital strings. >=20 > Signed-off-by: Wenchao Xia > --- > include/monitor/monitor.h | 37 -------------------------------------= > qapi-schema.json | 37 +++++++++++++++++++++++++++++++++++++= > 2 files changed, 37 insertions(+), 37 deletions(-) >=20 > -typedef enum QEvent { > - Q_EVENT_SHUTDOWN, > - Q_EVENT_RESET, > - Q_EVENT_POWERDOWN, > - Q_EVENT_STOP, > - Q_EVENT_RESUME, > - Q_EVENT_VNC_CONNECTED, > - Q_EVENT_VNC_INITIALIZED, > - Q_EVENT_VNC_DISCONNECTED, > - Q_EVENT_BLOCK_IO_ERROR, > - Q_EVENT_RTC_CHANGE, > - Q_EVENT_WATCHDOG, > - Q_EVENT_SPICE_CONNECTED, > - Q_EVENT_SPICE_INITIALIZED, > - Q_EVENT_SPICE_DISCONNECTED, > - Q_EVENT_BLOCK_JOB_COMPLETED, > - Q_EVENT_BLOCK_JOB_CANCELLED, > - Q_EVENT_BLOCK_JOB_ERROR, > - Q_EVENT_BLOCK_JOB_READY, > - Q_EVENT_DEVICE_DELETED, > - Q_EVENT_DEVICE_TRAY_MOVED, > - Q_EVENT_NIC_RX_FILTER_CHANGED, > - Q_EVENT_SUSPEND, > - Q_EVENT_SUSPEND_DISK, > - Q_EVENT_WAKEUP, > - Q_EVENT_BALLOON_CHANGE, > - Q_EVENT_SPICE_MIGRATE_COMPLETED, > - Q_EVENT_GUEST_PANICKED, > - Q_EVENT_BLOCK_IMAGE_CORRUPTED, > - > - /* Add to 'monitor_event_names' array in monitor.c when > - * defining new events here */ > - > - Q_EVENT_MAX, > -} QEvent; > - > int monitor_cur_is_qmp(void); > =20 > void monitor_protocol_event(QEvent event, QObject *data); > diff --git a/qapi-schema.json b/qapi-schema.json > index 60f3fd1..fbc1fab 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -29,6 +29,43 @@ > 'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] } > =20 > ## > +# @QEvent Again, see my comment in 3/6 wondering wheter we should fix the code generation python to special-case QEVENT when converting this enum into C code, rather than adding lots of churn. I see why you split the documentation patch into 6/6 - to let this one focus on just minimal code motion. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V31eLqGPgMSG1tpBdUAKmb2fLi52LRDg4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSZZKCAAoJEKeha0olJ0NqImYIAKuJPSoe+aBdEyzrW/UyLorH JBpEBnsMFxka+SBgeozU4LKkx3JbcC8hFU+3T1O9o1skxHXVdSEUPlohbCT6qmjI X7aMDChOrAQQ35MJoUV7EDrB9FEbxvLh5bmhiVSz3f+BKcVha3R13bHD4TOJyd2i bHyYVrqvkVHXelenMiAMx2VVlirhtrwMYkv1DeX7JJZ4WsHjtvwOF29ZvGQ/Bd7m xgy9j4grAG74wlazfcDDFWvt/4y05NDPAernaVgb3Mxi1Bvv8lyZKQlpmB3qZlXu 3mnOCQI3LvDGtxMcFy6wK5SVV8H3LISeYfNGqfkqkBTu0hZcE4G2S/LyW1eKMv4= =MpKD -----END PGP SIGNATURE----- --V31eLqGPgMSG1tpBdUAKmb2fLi52LRDg4--