From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMOT-00045d-Sz for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:48:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYMOP-0002ee-1P for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:48:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMOO-0002eT-OI for qemu-devel@nongnu.org; Mon, 21 Oct 2013 16:48:00 -0400 Message-ID: <526592F7.6030003@redhat.com> Date: Mon, 21 Oct 2013 21:47:51 +0100 From: Eric Blake MIME-Version: 1.0 References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382321765-29052-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1382321765-29052-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7pscnD9NCAIb3VLXLNx5usoEag4mMkpmT" Subject: Re: [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7pscnD9NCAIb3VLXLNx5usoEag4mMkpmT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/21/2013 03:16 AM, Wenchao Xia wrote: > Use the generated table in qapi-types.h. >=20 > Signed-off-by: Wenchao Xia > --- > monitor.c | 36 ++---------------------------------- > 1 files changed, 2 insertions(+), 34 deletions(-) Reviewed-by: Eric Blake (but may change if you rebase things to avoid churn in 3/5) > @@ -1070,7 +1038,7 @@ EventInfoList *qmp_query_events(Error **errp) > QEvent e; > =20 > for (e =3D 0 ; e < Q_EVENT_MAX ; e++) { > - const char *event_name =3D monitor_event_names[e]; > + const char *event_name =3D QEvent_lookup[e]; > assert(event_name !=3D NULL); > info =3D g_malloc0(sizeof(*info)); > info->value =3D g_malloc0(sizeof(*info->value)); >=20 Remember this spot in patch 6/6... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7pscnD9NCAIb3VLXLNx5usoEag4mMkpmT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSZZL3AAoJEKeha0olJ0NqwMEIAIaTzCv/Z8VIZGDHrj3Dr9An QSmR8NJ+BQKBtiXG80ej98+A73lNJ4EWgSSOEUw4aiuovsglZDMACJzBs4alm7J9 JX3vyBl4ggEAZn/lYrl+VQKbXaaOggGbNzWu168ixveB+ErUwbLaOfnc4suWVfnW lEJ7V3MGAUBiuUZga83lXNjPxVaeAQd439txxDMS2QiY3qrXaGV9orSfWV1Zf0Nj S9x42lnvGBeZ7iUCf9u5Mkt7rB1Vl224RAqTJKW7XVjQK2FvuCCEq/qpDJ6D4D6Q qyEajCvIsnlXEh+r1rX+/u0NzvXQVakMMmi30vFOYkhXFBu1+anUMozMykHmQeM= =ez0o -----END PGP SIGNATURE----- --7pscnD9NCAIb3VLXLNx5usoEag4mMkpmT--