From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMej-00042p-Ga for qemu-devel@nongnu.org; Mon, 21 Oct 2013 17:04:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYMef-0007ml-0b for qemu-devel@nongnu.org; Mon, 21 Oct 2013 17:04:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYMee-0007mh-Op for qemu-devel@nongnu.org; Mon, 21 Oct 2013 17:04:48 -0400 Message-ID: <526596D7.6000909@redhat.com> Date: Mon, 21 Oct 2013 22:04:23 +0100 From: Eric Blake MIME-Version: 1.0 References: <20131020145406.GA17618@type> <1382280980-21676-1-git-send-email-samuel.thibault@ens-lyon.org> <1382280980-21676-16-git-send-email-samuel.thibault@ens-lyon.org> In-Reply-To: <1382280980-21676-16-git-send-email-samuel.thibault@ens-lyon.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DeVuC5pId58Sh6N7An3poXB7iR5jIRcqv" Subject: Re: [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , qemu-devel@nongnu.org Cc: Yann Bordenave , Guillaume Subiron This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DeVuC5pId58Sh6N7An3poXB7iR5jIRcqv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/20/2013 03:56 PM, Samuel Thibault wrote: > This patchs adds parameters to manage some new options in the qemu -net= > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given i= n > argument to the qemu command. > Defaults parameters are respectively fc00::1, fc00::, /64 and fc00::2. >=20 > Signed-off-by: Yann Bordenave > --- Just focusing on interface for now... > +++ b/qapi-schema.json > @@ -2807,6 +2807,12 @@ > # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP= option > # to the guest > # > +# @ip6_prefix: #optional IPv6 network prefix Please mention '(since 1.8)' for each new field. Also, this command doesn't have any '_', so your new field names should be named with '-', as in @ip6-prefix > +# > +# @ip6_host: guest-visible IPv6 address of the host > +# > +# @ip6_dns: guest-visible IPv6 address of the virtual nameserver > +# > # @smb: #optional root directory of the built-in SMB server > # > # @smbserver: #optional IP address of the built-in SMB server > @@ -2820,20 +2826,23 @@ > ## > + '*ip6_prefix': 'str', Why is this a str instead of an integer? > + '*ip6_host': 'str', > + '*ip6_dns': 'str', These look okay (other than the - vs _ issue) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DeVuC5pId58Sh6N7An3poXB7iR5jIRcqv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSZZbXAAoJEKeha0olJ0NqJF8IAIuDAigdWx5jmrxzJfU1rn9a 4TtBjVxHGDihVzto93XXsoGbYx13sF8BQGmQ5lbI2+moeXv/Y4oK/Tjsh0KrcKHB uPeYsiwXEd9EnTfbOhfl08bInFX+liq+D9nwh4yA6he4gNdBvUGcsRUEuCs2vJWb BfzsKh2zd8tjos435p1mKzREbsOFY5dYyyji0x8/dUeuQT9VRnu4n5lhRRNx8q+A qEBXVwrfWXrxHSCxakIG0jYIAYfpqqRkHQZbo4PvyhHHjyUznhPk55rrAtOMobjj b1ttkI4MGQI7mr5Qy52A0P4eLaxxmwrPcSD4mWE/YhGGjFA7islkR4lIfOcg7OA= =HT6M -----END PGP SIGNATURE----- --DeVuC5pId58Sh6N7An3poXB7iR5jIRcqv--