From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYRww-0000Ks-2t for qemu-devel@nongnu.org; Mon, 21 Oct 2013 22:44:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYRwn-0001K6-OZ for qemu-devel@nongnu.org; Mon, 21 Oct 2013 22:44:02 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:45564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYRwn-0001Hu-5P for qemu-devel@nongnu.org; Mon, 21 Oct 2013 22:43:53 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Oct 2013 08:13:34 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id D2F46394004D for ; Tue, 22 Oct 2013 08:13:09 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9M2hQ0U39059636 for ; Tue, 22 Oct 2013 08:13:27 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9M2hSlu019286 for ; Tue, 22 Oct 2013 08:13:29 +0530 Message-ID: <5265E64F.40304@linux.vnet.ibm.com> Date: Tue, 22 Oct 2013 10:43:27 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1382321765-29052-4-git-send-email-xiawenc@linux.vnet.ibm.com> <5265917D.3000903@redhat.com> In-Reply-To: <5265917D.3000903@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com 于 2013/10/22 4:41, Eric Blake 写道: > On 10/21/2013 03:16 AM, Wenchao Xia wrote: >> The define will be moved to qapi-schema.json later, so rename the >> prefix to match its naming style. > Wouldn't it be simpler to fix the code generator to special case QEvent > to turn into QEVENT, instead of having to go through this churn? But if > we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical: > >> Also fixed code style error reported in spice-core.c. >> >> Signed-off-by: Wenchao Xia >> --- >> balloon.c | 2 +- >> block.c | 4 +- >> block/qcow2-refcount.c | 2 +- >> blockdev.c | 4 +- >> blockjob.c | 5 ++- >> cpus.c | 2 +- >> hw/acpi/core.c | 2 +- >> hw/core/qdev.c | 2 +- >> hw/misc/pvpanic.c | 2 +- >> hw/net/virtio-net.c | 2 +- >> hw/watchdog/watchdog.c | 2 +- >> include/monitor/monitor.h | 58 +++++++++++++++++----------------- >> monitor.c | 74 ++++++++++++++++++++++---------------------- >> target-s390x/kvm.c | 2 +- >> ui/spice-core.c | 8 ++-- >> ui/vnc.c | 6 ++-- >> vl.c | 14 ++++---- >> 17 files changed, 96 insertions(+), 95 deletions(-) > If no one else is as opposed to the Q_EVENT naming as I seem to be, then > you can add my reluctant > > Reviewed-by: Eric Blake > > in that your change is mechanical and correct. > Personally I think less special case is better, and there is no harm to do a mechanical prefix change in code. Markus, can I have your opinion? also cc qapi-types.py author Anthony.