From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYT0a-00079T-LE for qemu-devel@nongnu.org; Mon, 21 Oct 2013 23:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYT0U-0002jb-Qj for qemu-devel@nongnu.org; Mon, 21 Oct 2013 23:51:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYT0U-0002jR-I9 for qemu-devel@nongnu.org; Mon, 21 Oct 2013 23:51:46 -0400 Message-ID: <5265F63E.6040605@redhat.com> Date: Tue, 22 Oct 2013 04:51:26 +0100 From: Eric Blake MIME-Version: 1.0 References: <1382412341-1173-1-git-send-email-lilei@linux.vnet.ibm.com> <1382412341-1173-15-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1382412341-1173-15-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kXbUxEVMSK9mV3tmuHul56jvkElBmXBaX" Subject: Re: [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li , qemu-devel@nongnu.org Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, "libvir-list@redhat.com" , mdroth@linux.vnet.ibm.com, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, pbonzini@redhat.com, rcj@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kXbUxEVMSK9mV3tmuHul56jvkElBmXBaX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/22/2013 04:25 AM, Lei Li wrote: > Introduce new RanState RAN_STATE_FLIPPING_MIGRATE and > add it to runstate_needs_reset(). >=20 > Signed-off-by: Lei Li > --- > qapi-schema.json | 11 +++++++---- > vl.c | 12 +++++++++++- > 2 files changed, 18 insertions(+), 5 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 523a5b2..8178d0c 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -176,12 +176,15 @@ > # @watchdog: the watchdog action is configured to pause and has been t= riggered > # > # @guest-panicked: guest has been panicked as a result of guest OS pan= ic > +# > +# @flipping-migrate: guest is paused to start unix_page_flipping migra= tion > +# process We probably ought to enhance the docs to mention '(since 1.8)' for this field (and likewise for other enum values added after the original introduction of the enum). Last time we added a new user-visible runstate, it broke migration with older libvirt versions that weren't prepared to see the new state (hmm, I need to check if libvirt has fixed that in the meantime; adding a cc...). Paolo's advice at the time was that it is okay to require a new libvirt when using a new qemu, and that libvirt should be taught to treat all unknown RunState as if they were 'running'; although for this particular addition it might be nicer to have libvirt lump 'inmigrate' and 'flipping-migrate' to the same usage. > ## > { 'enum': 'RunState', > - 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'pause= d', > - 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm'= , > - 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog',= > - 'guest-panicked' ] } > + 'data': [ 'debug', 'flipping-migrate', 'inmigrate', 'internal-error'= , > + 'io-error', 'paused', 'postmigrate', 'prelaunch', 'finish-= migrate', > + 'restore-vm', 'running', 'save-vm', 'shutdown', 'suspended= ', > + 'watchdog', 'guest-panicked' ] } > =20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kXbUxEVMSK9mV3tmuHul56jvkElBmXBaX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSZfY+AAoJEKeha0olJ0Nqh6kH/j/saSK5bSCB//D72R6GIL3W GONX9fIvZUm63Uo/l13anp/WItFTqjgXVdjLEyQSiMFJ7nCt4zTtLofBrSMuSjq4 XF+GgEfmV8QMoF8C9GvXuF49xLHyF8grPlG3W3tluK/0xDAoqpr85V73xB2SaBNI BZEQz8wbfxiBfh8pDcS53w7EKOl7ZA1QbZNtiGtC912Gz3BNymTnQjdY2QJNLMaH LpUcMaAuhFH80srgIxI7okP6JUuaWIdcwL19E5LdTLfqp4KJnTE6YqI0ZwiG2v7y XSH0dPgNJRKu7FMmhDijohdOQYCBHhqjhVev8zmk2ozF0lQIEctde2bBsU2Xdus= =W+zw -----END PGP SIGNATURE----- --kXbUxEVMSK9mV3tmuHul56jvkElBmXBaX--