From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYWdJ-0001Lf-Ve for qemu-devel@nongnu.org; Tue, 22 Oct 2013 03:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYWdA-0000ZR-Sy for qemu-devel@nongnu.org; Tue, 22 Oct 2013 03:44:05 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:52614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYWdA-0000Vb-Aa for qemu-devel@nongnu.org; Tue, 22 Oct 2013 03:43:56 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Oct 2013 13:13:44 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id D553239405D7 for ; Tue, 22 Oct 2013 11:57:52 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9M6S9ew43909346 for ; Tue, 22 Oct 2013 11:58:09 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9M6SBKX030478 for ; Tue, 22 Oct 2013 11:58:12 +0530 Message-ID: <52661AF8.4000508@linux.vnet.ibm.com> Date: Tue, 22 Oct 2013 14:28:08 +0800 From: Lei Li MIME-Version: 1.0 References: <1382412341-1173-1-git-send-email-lilei@linux.vnet.ibm.com> <1382412341-1173-15-git-send-email-lilei@linux.vnet.ibm.com> <5265F63E.6040605@redhat.com> In-Reply-To: <5265F63E.6040605@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aarcange@redhat.com, quintela@redhat.com, "libvir-list@redhat.com" , mdroth@linux.vnet.ibm.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, Anthony Liguori , lagarcia@br.ibm.com, pbonzini@redhat.com, rcj@linux.vnet.ibm.com On 10/22/2013 11:51 AM, Eric Blake wrote: > On 10/22/2013 04:25 AM, Lei Li wrote: >> Introduce new RanState RAN_STATE_FLIPPING_MIGRATE and >> add it to runstate_needs_reset(). >> >> Signed-off-by: Lei Li >> --- >> qapi-schema.json | 11 +++++++---- >> vl.c | 12 +++++++++++- >> 2 files changed, 18 insertions(+), 5 deletions(-) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 523a5b2..8178d0c 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -176,12 +176,15 @@ >> # @watchdog: the watchdog action is configured to pause and has been triggered >> # >> # @guest-panicked: guest has been panicked as a result of guest OS panic >> +# >> +# @flipping-migrate: guest is paused to start unix_page_flipping migration >> +# process > We probably ought to enhance the docs to mention '(since 1.8)' for this > field (and likewise for other enum values added after the original > introduction of the enum). Hi Eric, Sure, will do. BTW, I was hoping this feature could be accepted and merged to QEMU 1.7 release. > > Last time we added a new user-visible runstate, it broke migration with > older libvirt versions that weren't prepared to see the new state (hmm, > I need to check if libvirt has fixed that in the meantime; adding a > cc...). Paolo's advice at the time was that it is okay to require a new > libvirt when using a new qemu, and that libvirt should be taught to > treat all unknown RunState as if they were 'running'; although for this > particular addition it might be nicer to have libvirt lump 'inmigrate' > and 'flipping-migrate' to the same usage. I am not sure whether these two runstate could be lumped with same usage in libvirt. Whatever, looks like 'inmigrate' has a transition from 'prelaunch' to it in QEMU, which reminds me that it may need to add another transition from 'prelaunch' to 'flipping-migrate' too. > >> ## >> { 'enum': 'RunState', >> - 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused', >> - 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm', >> - 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog', >> - 'guest-panicked' ] } >> + 'data': [ 'debug', 'flipping-migrate', 'inmigrate', 'internal-error', >> + 'io-error', 'paused', 'postmigrate', 'prelaunch', 'finish-migrate', >> + 'restore-vm', 'running', 'save-vm', 'shutdown', 'suspended', >> + 'watchdog', 'guest-panicked' ] } >> > -- Lei