From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51785)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VYXh8-0000Ac-FR
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 04:52:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VYXgz-0005Bg-Hk
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 04:52:06 -0400
Received: from e28smtp05.in.ibm.com ([122.248.162.5]:36665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VYXgy-0005B6-TM
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 04:51:57 -0400
Received: from /spool/local
	by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Tue, 22 Oct 2013 14:21:52 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp01.in.ibm.com (Postfix) with ESMTP id 2C07DE1912
	for <qemu-devel@nongnu.org>; Tue, 22 Oct 2013 12:27:07 +0530 (IST)
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r9M6tWVW35061930
	for <qemu-devel@nongnu.org>; Tue, 22 Oct 2013 12:25:33 +0530
Received: from d28av02.in.ibm.com (localhost [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	r9M6tZ6H030514
	for <qemu-devel@nongnu.org>; Tue, 22 Oct 2013 12:25:35 +0530
Message-ID: <52662165.8000300@linux.vnet.ibm.com>
Date: Tue, 22 Oct 2013 14:55:33 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382321765-29052-7-git-send-email-xiawenc@linux.vnet.ibm.com>
	<526595ED.5090506@redhat.com>
In-Reply-To: <526595ED.5090506@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com

于 2013/10/22 5:00, Eric Blake 写道:
> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>>   qapi-schema.json |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 files changed, 56 insertions(+), 0 deletions(-)
> Incomplete.  Now that you are actually using the enum (see the spot I
> pointed out in 5/6), you ALSO need to change:
>
> -{ 'type': 'EventInfo', 'data': {'name': 'str'} }
> +{ 'type': 'EventInfo', 'data': {'name': 'QEvent'} }
>
> and make use of the enum in the QAPI documentation.
>
   I just found QEvent is a int(enum) so this change can't be done.
Is there a way to tell use QEvent's correspond string? Add a new
way to specify enum's correspond string automatically? for example:

{ 'type': 'EventInfo', 'data': {'name': '&QEvent'}