From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VYbKp-0001a7-4Q
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 08:45:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VYbKf-0001Lw-VW
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 08:45:18 -0400
Received: from e28smtp04.in.ibm.com ([122.248.162.4]:44207)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VYbKf-0001Gz-9j
	for qemu-devel@nongnu.org; Tue, 22 Oct 2013 08:45:09 -0400
Received: from /spool/local
	by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Tue, 22 Oct 2013 18:14:57 +0530
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by d28dlp01.in.ibm.com (Postfix) with ESMTP id 30147E00CF
	for <qemu-devel@nongnu.org>; Tue, 22 Oct 2013 13:05:24 +0530 (IST)
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r9M7adU332309424
	for <qemu-devel@nongnu.org>; Tue, 22 Oct 2013 13:06:44 +0530
Received: from d28av02.in.ibm.com (localhost [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	r9M7XlAi030368
	for <qemu-devel@nongnu.org>; Tue, 22 Oct 2013 13:03:47 +0530
Message-ID: <52662A59.9010205@linux.vnet.ibm.com>
Date: Tue, 22 Oct 2013 15:33:45 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382321765-29052-7-git-send-email-xiawenc@linux.vnet.ibm.com>
	<526595ED.5090506@redhat.com> <52662165.8000300@linux.vnet.ibm.com>
In-Reply-To: <52662165.8000300@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com

于 2013/10/22 14:55, Wenchao Xia 写道:
> 于 2013/10/22 5:00, Eric Blake 写道:
>> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>>> ---
>>>   qapi-schema.json |   56 
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   1 files changed, 56 insertions(+), 0 deletions(-)
>> Incomplete.  Now that you are actually using the enum (see the spot I
>> pointed out in 5/6), you ALSO need to change:
>>
>> -{ 'type': 'EventInfo', 'data': {'name': 'str'} }
>> +{ 'type': 'EventInfo', 'data': {'name': 'QEvent'} }
>>
>> and make use of the enum in the QAPI documentation.
>>
>   I just found QEvent is a int(enum) so this change can't be done.
> Is there a way to tell use QEvent's correspond string? Add a new
> way to specify enum's correspond string automatically? for example:
>
> { 'type': 'EventInfo', 'data': {'name': '&QEvent'}
>
   I just found visitor will do it for me automatically, so it is not
a problem, sorry for the disturbing messsage.