[Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported

[Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported

[Peter Lieven]

currently it is not possible to distinguish by exitcode if there
has been an error or if bdrv_check is not supported by the image
format. Change the exitcode from 1 to 255 for the latter case.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 qemu-img.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-img.c b/qemu-img.c
index 9fb3016..163aa3f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -609,7 +609,7 @@ static int img_check(int argc, char **argv)
         if (output_format == OFORMAT_HUMAN) {
             error_report("This image format does not support checks");
         }
-        ret = 1;
+        ret = 255;
         goto fail;
     }
 
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On 10/22/2013 09:26 AM, Peter Lieven wrote:
> currently it is not possible to distinguish by exitcode if there
> has been an error or if bdrv_check is not supported by the image
> format. Change the exitcode from 1 to 255 for the latter case.

Why 255?  Sure, 'xargs' handles $?=255 differently than most other
status, but in general, $? > 128 starts to be ambiguous with death by
signal (on the other hand, most systems stop at 64 signals rather than
128).  Most applications that use differentiated exit status just use 1
and 2, rather than 1 and 255.

> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  qemu-img.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

But I don't care strongly enough to reject this, so if no one else
complains about the choice:
Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 9fb3016..163aa3f 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -609,7 +609,7 @@ static int img_check(int argc, char **argv)
>          if (output_format == OFORMAT_HUMAN) {
>              error_report("This image format does not support checks");
>          }
> -        ret = 1;
> +        ret = 255;
>          goto fail;
>      }
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

Re: [Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported

[Peter Lieven]

On 22.10.2013 10:34, Eric Blake wrote:
> On 10/22/2013 09:26 AM, Peter Lieven wrote:
>> currently it is not possible to distinguish by exitcode if there
>> has been an error or if bdrv_check is not supported by the image
>> format. Change the exitcode from 1 to 255 for the latter case.
> Why 255?  Sure, 'xargs' handles $?=255 differently than most other
> status, but in general, $? > 128 starts to be ambiguous with death by
> signal (on the other hand, most systems stop at 64 signals rather than
> 128).  Most applications that use differentiated exit status just use 1
> and 2, rather than 1 and 255.
I would also be fine with 63. Someone started to make some
choices for check->leaks, check->corruptions using 2,3, ...
I wanted to avoid conflicts if someone adds a 4,5,6 ...

Peter