From: Peter Lieven <pl@kamp.de>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported
Date: Tue, 22 Oct 2013 10:36:09 +0200 [thread overview]
Message-ID: <526638F9.8020107@kamp.de> (raw)
In-Reply-To: <5266387D.1080506@redhat.com>
On 22.10.2013 10:34, Eric Blake wrote:
> On 10/22/2013 09:26 AM, Peter Lieven wrote:
>> currently it is not possible to distinguish by exitcode if there
>> has been an error or if bdrv_check is not supported by the image
>> format. Change the exitcode from 1 to 255 for the latter case.
> Why 255? Sure, 'xargs' handles $?=255 differently than most other
> status, but in general, $? > 128 starts to be ambiguous with death by
> signal (on the other hand, most systems stop at 64 signals rather than
> 128). Most applications that use differentiated exit status just use 1
> and 2, rather than 1 and 255.
I would also be fine with 63. Someone started to make some
choices for check->leaks, check->corruptions using 2,3, ...
I wanted to avoid conflicts if someone adds a 4,5,6 ...
Peter
prev parent reply other threads:[~2013-10-22 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 8:26 [Qemu-devel] [PATCH] qemu-img: add special exit code if bdrv_check is not supported Peter Lieven
2013-10-22 8:34 ` Eric Blake
2013-10-22 8:36 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526638F9.8020107@kamp.de \
--to=pl@kamp.de \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).