From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39378)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1VZGy0-0003Gr-0I
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:12:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1VZGxu-0003hn-Bj
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:12:31 -0400
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:60044 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1VZGxu-0003hX-0J
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:12:26 -0400
Message-ID: <5268E47B.4060107@kamp.de>
Date: Thu, 24 Oct 2013 11:12:27 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1382600811-20043-1-git-send-email-pl@kamp.de>
	<1382600811-20043-18-git-send-email-pl@kamp.de>
	<5268E41C.9050406@redhat.com>
In-Reply-To: <5268E41C.9050406@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv6 17/17] block/raw: copy BlockLimits on
	raw_open
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com

On 24.10.2013 11:10, Paolo Bonzini wrote:
> Il 24/10/2013 08:46, Peter Lieven ha scritto:
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   block/raw_bsd.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
>> index b0dd23f..49ac18c 100644
>> --- a/block/raw_bsd.c
>> +++ b/block/raw_bsd.c
>> @@ -150,6 +150,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags,
>>                       Error **errp)
>>   {
>>       bs->sg = bs->file->sg;
>> +    bs->bl = bs->file->bl;
>>       return 0;
>>   }
>>   
>>
> This must be moved before the introduction of BlockLimits in the iscsi
> driver, or patches that use BlockLimits in block.c will not have any effect.
You are the first to mention this. I was thinking the whole series will
be seen as once so it shouldn't matter.

Peter