From: Paolo Bonzini <pbonzini@redhat.com>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com,
qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com,
mdroth@linux.vnet.ibm.com, lagarcia@br.ibm.com,
rcj@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 03/17] migration: add migrate_unix_page_flipping()
Date: Thu, 24 Oct 2013 14:54:36 +0100 [thread overview]
Message-ID: <5269269C.8050008@redhat.com> (raw)
In-Reply-To: <1382412341-1173-4-git-send-email-lilei@linux.vnet.ibm.com>
Il 22/10/2013 04:25, Lei Li ha scritto:
> Add migrate_unix_page_flipping() to check if
> MIGRATION_CAPABILITY_UNIX_PAGE_FLIPPING is enabled.
>
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
> include/migration/migration.h | 3 +++
> migration.c | 9 +++++++++
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index 140e6b4..7e5d01a 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -131,10 +131,13 @@ void migrate_add_blocker(Error *reason);
> void migrate_del_blocker(Error *reason);
>
> bool migrate_rdma_pin_all(void);
> +
> bool migrate_zero_blocks(void);
>
> bool migrate_auto_converge(void);
>
> +bool migrate_unix_page_flipping(void);
> +
> int xbzrle_encode_buffer(uint8_t *old_buf, uint8_t *new_buf, int slen,
> uint8_t *dst, int dlen);
> int xbzrle_decode_buffer(uint8_t *src, int slen, uint8_t *dst, int dlen);
> diff --git a/migration.c b/migration.c
> index 2b1ab20..4ac466b 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -541,6 +541,15 @@ int64_t migrate_xbzrle_cache_size(void)
> return s->xbzrle_cache_size;
> }
>
> +bool migrate_unix_page_flipping(void)
> +{
> + MigrationState *s;
> +
> + s = migrate_get_current();
> +
> + return s->enabled_capabilities[MIGRATION_CAPABILITY_UNIX_PAGE_FLIPPING];
> +}
> +
> /* migration thread support */
>
> static void *migration_thread(void *opaque)
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2013-10-24 13:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 3:25 [Qemu-devel] [PATCH 0/17 v2] Localhost migration with side channel for ram Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 01/17] rename is_active to is_block_active Lei Li
2013-10-24 13:46 ` Paolo Bonzini
2013-10-25 4:10 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 02/17] QAPI: introduce magration capability unix_page_flipping Lei Li
2013-10-24 13:52 ` Paolo Bonzini
2013-10-25 4:11 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 03/17] migration: add migrate_unix_page_flipping() Lei Li
2013-10-24 13:54 ` Paolo Bonzini [this message]
2013-10-22 3:25 ` [Qemu-devel] [PATCH 04/17] qmp-command.hx: add missing docs for migration capabilites Lei Li
2013-10-24 13:57 ` Paolo Bonzini
2013-10-25 4:11 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 05/17] migration-local: add QEMUFileLocal with socket based QEMUFile Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 06/17] migration-local: introduce qemu_fopen_socket_local() Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 07/17] migration-local: add send_pipefd() Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 08/17] migration-local: add recv_pipefd() Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 09/17] migration-local: override before_ram_iterate to send pipefd Lei Li
2013-10-24 14:07 ` Paolo Bonzini
2013-10-25 4:16 ` Lei Li
2013-10-25 4:38 ` Lei Li
2013-10-25 7:23 ` Paolo Bonzini
2013-10-25 12:15 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 10/17] migration-local: override save_page for page transmit Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 11/17] savevm: adjust ram_control_save_page for page flipping Lei Li
2013-10-24 14:09 ` Paolo Bonzini
2013-10-22 3:25 ` [Qemu-devel] [PATCH 12/17] migration-local: override hook_ram_load Lei Li
2013-10-24 14:06 ` Paolo Bonzini
2013-10-22 3:25 ` [Qemu-devel] [PATCH 13/17] migration-unix: replace qemu_fopen_socket with qemu_fopen_socket_local Lei Li
2013-10-24 14:10 ` Paolo Bonzini
2013-10-25 4:18 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_FLIPPING_MIGRATE Lei Li
2013-10-22 3:51 ` Eric Blake
2013-10-22 6:28 ` Lei Li
2013-10-22 8:10 ` Eric Blake
2013-10-24 14:11 ` Paolo Bonzini
2013-10-24 14:16 ` Paolo Bonzini
2013-10-24 14:13 ` Paolo Bonzini
2013-10-25 4:30 ` Lei Li
2013-10-25 7:31 ` Paolo Bonzini
2013-10-25 12:16 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 15/17] migration-unix: page flipping support on unix outgoing Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping Lei Li
2013-10-24 14:15 ` Paolo Bonzini
2013-10-25 4:33 ` Lei Li
2013-10-22 3:25 ` [Qemu-devel] [PATCH 17/17] hmp: better format for info migrate_capabilities Lei Li
2013-10-24 14:17 ` Paolo Bonzini
2013-10-24 14:17 ` [Qemu-devel] [PATCH 0/17 v2] Localhost migration with side channel for ram Paolo Bonzini
2013-10-25 5:58 ` Lei Li
2013-10-25 7:30 ` Paolo Bonzini
2013-10-25 9:12 ` Anthony Liguori
2013-10-25 12:24 ` Lei Li
2013-11-21 8:45 ` Lei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5269269C.8050008@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lagarcia@br.ibm.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).