Re: [Qemu-devel] [PATCH 17/17] hmp: better format for info migrate_capabilities

[Paolo Bonzini <pbonzini@redhat.com>]

Il 22/10/2013 04:25, Lei Li ha scritto:
> As there might be more capabilities introduced, better to display
> it in lines.
> 
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  hmp.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hmp.c b/hmp.c
> index 32ee285..dcfa2f9 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -226,13 +226,12 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
>      caps = qmp_query_migrate_capabilities(NULL);
>  
>      if (caps) {
> -        monitor_printf(mon, "capabilities: ");
> +        monitor_printf(mon, "Capabilities:\n");
>          for (cap = caps; cap; cap = cap->next) {
> -            monitor_printf(mon, "%s: %s ",
> +            monitor_printf(mon, "%s: %s\n",
>                             MigrationCapability_lookup[cap->value->capability],
>                             cap->value->state ? "on" : "off");
>          }
> -        monitor_printf(mon, "\n");
>      }
>  
>      qapi_free_MigrationCapabilityStatusList(caps);
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>