From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZLir-0007Sw-74 for qemu-devel@nongnu.org; Thu, 24 Oct 2013 10:17:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZLii-0005ff-Qd for qemu-devel@nongnu.org; Thu, 24 Oct 2013 10:17:13 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:59931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZLii-0005f9-Ag for qemu-devel@nongnu.org; Thu, 24 Oct 2013 10:17:04 -0400 Received: by mail-wi0-f180.google.com with SMTP id ey11so2622457wid.13 for ; Thu, 24 Oct 2013 07:17:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52692BDC.2060501@redhat.com> Date: Thu, 24 Oct 2013 15:17:00 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1382412341-1173-1-git-send-email-lilei@linux.vnet.ibm.com> <1382412341-1173-18-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1382412341-1173-18-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/17] hmp: better format for info migrate_capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com Il 22/10/2013 04:25, Lei Li ha scritto: > As there might be more capabilities introduced, better to display > it in lines. > > Signed-off-by: Lei Li > --- > hmp.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 32ee285..dcfa2f9 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -226,13 +226,12 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict) > caps = qmp_query_migrate_capabilities(NULL); > > if (caps) { > - monitor_printf(mon, "capabilities: "); > + monitor_printf(mon, "Capabilities:\n"); > for (cap = caps; cap; cap = cap->next) { > - monitor_printf(mon, "%s: %s ", > + monitor_printf(mon, "%s: %s\n", > MigrationCapability_lookup[cap->value->capability], > cap->value->state ? "on" : "off"); > } > - monitor_printf(mon, "\n"); > } > > qapi_free_MigrationCapabilityStatusList(caps); > Reviewed-by: Paolo Bonzini