From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VZQ0s-0002Y5-6v
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 14:52:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VZQ0j-00056s-D4
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 14:52:06 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52696C48.9040505@twiddle.net>
Date: Thu, 24 Oct 2013 11:51:52 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <526947CA.4020504@gmail.com> <52694896.5040304@gmail.com>
In-Reply-To: <52694896.5040304@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/19] General Support for VSX Helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>

On 10/24/2013 09:19 AM, Tom Musta wrote:
> 
> +#define GEN_VSX_HELPER_2(name, op1, op2, inval, type)                         \
> +static void gen_##name(DisasContext * ctx)                                    \
> +{                                                                             \
> +    TCGv_i32 opc;                                                             \
> +    if (unlikely(!ctx->vsx_enabled)) {                                        \
> +        gen_exception(ctx, POWERPC_EXCP_VSXU);                                \
> +        return;                                                               \
> +    }                                                                         \
> +    /* NIP cannot be restored if the memory exception comes from an helper */ \
> +    gen_update_nip(ctx, ctx->nip - 4);                                        \
> +    opc = tcg_const_i32(ctx->opcode);                                         \
> +    gen_helper_##name(cpu_env, opc);                                          \
> +    tcg_temp_free_i32(opc);                                                   \
> +}

I'm not a fan of delaying decode to the helpers...

You're mostly doing this to avoid passing 3-4 arguments
for the register numbers?


r~