From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VZRtJ-0004zQ-GG
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 16:52:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VZRtD-00056L-Bl
	for qemu-devel@nongnu.org; Thu, 24 Oct 2013 16:52:25 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5269885C.1040704@twiddle.net>
Date: Thu, 24 Oct 2013 13:51:40 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <526947CA.4020504@gmail.com> <52694A7A.7070701@gmail.com>
In-Reply-To: <52694A7A.7070701@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 18/19] Add VSX ISA2.06 Integer Conversion
 Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>

On 10/24/2013 09:27 AM, Tom Musta wrote:
> This patch adds the VSX Integer Conversion instructions defined by
> V2.06 of the PowerPC ISA:
> 
>   - xscvdpsxds, xscvdpsxws, xscvdpuxds, xscvdpuxws
>   - xvcvdpsxds, xvcvdpsxws, xvcvdpuxds, xvcvdpuxws

>   - xvcvspsxds, xvcvspsxws, xvcvspuxds, xvcvspuxws
>   - xscvsxddp, xscvuxddp
>   - xvcvsxddp, xscvsxwdp, xvcvuxddp, xvcvuxwdp
>   - xvcvsxdsp, xscvsxwsp, xvcvuxdsp, xvcvuxwsp
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---

With a codingstyle fix,

Reviewed-by: Richard Henderson <rth@twiddle.net>

> +            xt.tfld = rnan;                                                  \
> +        }                                                                    \
> +        else {                                                               \
> +            xt.tfld = stp##_to_##ttp(xb.sfld, &env->fp_status);              \

Here.



r~