From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: "Michael W. Bombardieri" <mb@ii.net>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] qemu 1.6.1
Date: Thu, 24 Oct 2013 22:47:54 +0100 [thread overview]
Message-ID: <5269958A.50400@redhat.com> (raw)
In-Reply-To: <52694CC1.6040301@weilnetz.de>
Il 24/10/2013 17:37, Stefan Weil ha scritto:
> Yes, that works, too. It also fixes the problem with the assertion
> (tested with Wine).
>
> No, we cannot remove from_, because the same interface is also used
> for Linux and other hosts which don't have a 'current' variable.
> Or we would have to call qemu_coroutine_self() to get the current
> coroutine.
Yes, I was thinking of using qemu_coroutine_self().
By the way, can you post the two assembly language outputs for just
- CoroutineWin32 *from = DO_UPCAST(CoroutineWin32, base, from_);
+ CoroutineWin32 *from = DO_UPCAST(CoroutineWin32, base, current);
which AIUI works and is enough to fix the bug?
Paolo
next prev parent reply other threads:[~2013-10-24 21:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 7:39 [Qemu-devel] qemu 1.6.1 Michael W. Bombardieri
2013-10-23 9:00 ` Paolo Bonzini
2013-10-23 20:26 ` Stefan Weil
2013-10-24 10:38 ` Paolo Bonzini
2013-10-24 16:37 ` Stefan Weil
2013-10-24 21:47 ` Paolo Bonzini [this message]
2013-10-26 9:51 ` Stefan Weil
2013-10-27 6:54 ` Paolo Bonzini
2013-10-27 10:44 ` Stefan Weil
2013-10-27 15:38 ` Stefan Weil
2014-06-23 14:39 ` [Qemu-devel] broken win32 coroutines (was Re: qemu 1.6.1) Paolo Bonzini
2014-06-24 1:41 ` Michael W. Bombardieri
2014-06-24 5:22 ` Paolo Bonzini
2014-06-25 6:48 ` Michael W. Bombardieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5269958A.50400@redhat.com \
--to=pbonzini@redhat.com \
--cc=mb@ii.net \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).