From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZgJ4-0002hb-D5 for qemu-devel@nongnu.org; Fri, 25 Oct 2013 08:16:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZgIv-00006F-Gi for qemu-devel@nongnu.org; Fri, 25 Oct 2013 08:15:58 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:58667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZgIu-0008Tu-Q8 for qemu-devel@nongnu.org; Fri, 25 Oct 2013 08:15:49 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Oct 2013 17:45:42 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 2F4331258054 for ; Fri, 25 Oct 2013 17:46:14 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9PCIUgm38469748 for ; Fri, 25 Oct 2013 17:48:33 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9PCFZqm016411 for ; Fri, 25 Oct 2013 17:45:35 +0530 Message-ID: <526A60E4.9000407@linux.vnet.ibm.com> Date: Fri, 25 Oct 2013 20:15:32 +0800 From: Lei Li MIME-Version: 1.0 References: <1382412341-1173-1-git-send-email-lilei@linux.vnet.ibm.com> <1382412341-1173-10-git-send-email-lilei@linux.vnet.ibm.com> <526929A9.9030103@redhat.com> <5269F5B9.4020700@linux.vnet.ibm.com> <526A1C7E.8080506@redhat.com> In-Reply-To: <526A1C7E.8080506@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/17] migration-local: override before_ram_iterate to send pipefd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, quintela@redhat.com, mdroth@linux.vnet.ibm.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, Anthony Liguori , lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com On 10/25/2013 03:23 PM, Paolo Bonzini wrote: > Il 25/10/2013 05:38, Lei Li ha scritto: >> Just want to confirm, normally, should I take these 'otherwise looks >> good/ok' >> as a 'Reviewed-by' from you If the other comment is fixed in the update >> version? > Depends on how much the patch changes... right now I'm still expecting > some changes so I didn't really look much at the patch and didn't test > it. I prefer to take a more complete look at v3 before giving a > "formal" Reviewed-by. I see, thanks for your explanation. > > Paolo > -- Lei