From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36238)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VZhm5-0007C2-Ec
	for qemu-devel@nongnu.org; Fri, 25 Oct 2013 09:50:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1VZhlz-0004mM-TH
	for qemu-devel@nongnu.org; Fri, 25 Oct 2013 09:50:01 -0400
Message-ID: <526A76FC.2000603@gmail.com>
Date: Fri, 25 Oct 2013 08:49:48 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <526947CA.4020504@gmail.com> <526949E1.3010405@gmail.com>
	<5269852E.9000601@twiddle.net>
In-Reply-To: <5269852E.9000601@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 13/19] Add VSX ISA2.06 Multiply Add
	Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>

On 10/24/2013 3:38 PM, Richard Henderson wrote:
> On 10/24/2013 09:25 AM, Tom Musta wrote:
>>                                                 \
<snip>

>> +                ft1 = tp##_to_##btp(s->fld[i], &env->fp_status);              \
>> +                ft0 = btp##_##sum(ft0, ft1, &env->fp_status);                 \
>> +                xt.fld[i] = btp##_to_##tp(ft0, &env->fp_status);              \
<snip>
> You want to be using tp##muladd instead of widening to 128 bits.

Thanks for the suggestion, Richard.  I will try it.

>
>> +        s = &xt;                                                              \
>> +    }                                                                         \
>> +    else {                                                                    \
>> +        m = &xt;                                                              \
>
> Also be careful of the codingstyle.

To be fixed in V2 (checkpatch.pl missed this one).