From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZisi-0001Rz-9q for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:01:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZisZ-0000nL-CZ for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:00:56 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:49413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZisZ-0000nE-5t for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:00:47 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Oct 2013 09:00:45 -0600 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id EB33738C8056 for ; Fri, 25 Oct 2013 11:00:40 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23033.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9PF0fdx39518392 for ; Fri, 25 Oct 2013 15:00:41 GMT Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r9PF0frX011969 for ; Fri, 25 Oct 2013 11:00:41 -0400 Message-ID: <526A8797.3040901@linux.vnet.ibm.com> Date: Fri, 25 Oct 2013 11:00:39 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1382461164-8854-1-git-send-email-mrhines@linux.vnet.ibm.com> <5266DE16.8060508@redhat.com> In-Reply-To: <5266DE16.8060508@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, onom@us.ibm.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com On 10/22/2013 04:20 PM, Eric Blake wrote: > On 10/22/2013 05:59 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> As far as we can tell, all known bugs have been fixed, >> there as been very good participation in testing and running. >> >> 1. Parallel RDMA migrations are working >> 2. IPv6 migration is working >> 3. Libvirt patches are ready >> 4. virt-test is working >> >> Any objections to removing the experimental tag? >> >> There is one remaining bug: qemu-system-i386 does not compile >> with RDMA: I have very zero access to 32-bit hardware >> using RDMA, so this hasn't been much of a priority. It seems >> safer to *not* submit non-testable patch rather than submit >> submit a fix just for the sake of compiling =) >> >> Signed-off-by: Michael R. Hines >> --- >> >> TODO: >> ===== >> -1. 'migrate x-rdma:host:port' and '-incoming x-rdma' options will be >> +1. 'migrate rdma:host:port' and '-incoming rdma' options will be >> renamed to 'rdma' after the experimental phase of this work has >> completed upstream. > Shouldn't you remove step 1 and renumber the rest of the list > altogether, rather than just altering the comment to make it out-of-date? > Oops =) >> +++ b/qapi-schema.json >> @@ -615,7 +615,7 @@ >> # This feature allows us to minimize migration traffic for certain work >> # loads, by sending compressed difference of the pages >> # >> -# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is >> +# @rdma-pin-all: Controls whether or not the entire VM memory footprint is >> # mlock()'d on demand or all at once. Refer to docs/rdma.txt for usage. >> # Disabled by default. Experimental: may (or may not) be renamed after >> # further testing is complete. (since 1.6) > I'd also recommend tweaking this to say 'since 1.7', since the spelling > 'rdma-pin-all' is new to this release. > Ah, yes. =)