From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZitj-0003D5-Ma for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:02:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZita-0000wp-UB for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:01:59 -0400 Received: from mail-ea0-x22b.google.com ([2a00:1450:4013:c01::22b]:38877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZita-0000wf-N3 for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:01:50 -0400 Received: by mail-ea0-f171.google.com with SMTP id n15so716749ead.30 for ; Fri, 25 Oct 2013 08:01:49 -0700 (PDT) Message-ID: <526A87E2.9020705@gmail.com> Date: Fri, 25 Oct 2013 17:01:54 +0200 From: Jack Wang MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC] block io lost in the guest , possible related to qemu? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Kevin Wolf , Alexey Zaytsev , Stefan Hajnoczi Hi Experts, We've seen guest block io lost in a VM.any response will be helpful environment is: guest os: Ubuntu 1304 running busy database workload with xfs on a disk export with virtio-blk the exported vdb has very high infight io over 300. Some times later a lot io process in D state, looks a lot requests is lost in below storage stack. We're use qemu-kvm 1.0, host kernel 3.4.51 In qemu log of virtio-blk.c I found below commit, I wonder is it possible the workload generate some unknown reqests to qemu that lost in virtio_blk_handle_read? I do some fio test myself, I cann't generate so call unknown request type. Any response will be helpful. Jack commit 9e72c45033770b81b536ac6091e91807247cc25a Author: Alexey Zaytsev Date: Thu Dec 13 09:03:43 2012 +0200 virtio-blk: Return UNSUPP for unknown request types Currently, all unknown requests are treated as VIRTIO_BLK_T_IN Signed-off-by: Alexey Zaytsev Signed-off-by: Stefan Hajnoczi diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 92c745a..df57b35 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -398,10 +398,14 @@ static void virtio_blk_handle_request(VirtIOBlockReq *req, qemu_iovec_init_external(&req->qiov, &req->elem.out_sg[1], req->elem.out_num - 1); virtio_blk_handle_write(req, mrb); - } else { + } else if (type == VIRTIO_BLK_T_IN || type == VIRTIO_BLK_T_BARRIER) { + /* VIRTIO_BLK_T_IN is 0, so we can't just & it. */ qemu_iovec_init_external(&req->qiov, &req->elem.in_sg[0], req->elem.in_num - 1); virtio_blk_handle_read(req); + } else { + virtio_blk_req_complete(req, VIRTIO_BLK_S_UNSUPP); + g_free(req); } }