From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, chegu_vinod@hp.com,
qemu-devel@nongnu.org, owasserm@redhat.com, onom@us.ibm.com,
abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'
Date: Fri, 25 Oct 2013 11:03:28 -0400 [thread overview]
Message-ID: <526A8840.5020303@linux.vnet.ibm.com> (raw)
In-Reply-To: <52676BF6.7010305@redhat.com>
On 10/23/2013 02:25 AM, Paolo Bonzini wrote:
> Il 22/10/2013 21:20, Eric Blake ha scritto:
>>>> -# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is
>>>> +# @rdma-pin-all: Controls whether or not the entire VM memory footprint is
>>>> # mlock()'d on demand or all at once. Refer to docs/rdma.txt for usage.
>>>> # Disabled by default. Experimental: may (or may not) be renamed after
>>>> # further testing is complete. (since 1.6)
>> I'd also recommend tweaking this to say 'since 1.7', since the spelling
>> 'rdma-pin-all' is new to this release.
> I would also leave this as experimental for now.
>
> Basically the point of the "experimental" designation was to ensure that
> RDMA protocol changes might not preserve backwards compatibility. The
> capability is a separate thing from the protocol, as it would likely
> apply to any migration-over-RDMA implementation
>
> Paolo
>
Well, I tried posting libvirt support with this naming scheme,
but they didn't accepted.
Their reason (Daniel, I think) is valid: experimental implies that it
shouldn't be exposed in the management software until it is
deemed stable at some point.
As far we can tell, it is stable, and made very clear using the new
'setup' state in the migration state machine.
How would we expose it in libvirt as an experimental feature
without labeling it as an experimental feature?
- Michael
next prev parent reply other threads:[~2013-10-25 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 16:59 [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma' mrhines
2013-10-22 20:20 ` Eric Blake
2013-10-23 6:25 ` Paolo Bonzini
2013-10-25 15:03 ` Michael R. Hines [this message]
2013-10-25 15:14 ` Paolo Bonzini
2013-10-26 8:45 ` Michael R. Hines
2013-10-26 17:13 ` Paolo Bonzini
2013-10-25 15:00 ` Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526A8840.5020303@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=gokul@us.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=onom@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).