From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZivN-0005Wr-Dl for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:03:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZivE-0001Js-G5 for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:03:41 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:42293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZivE-0001Jm-Al for qemu-devel@nongnu.org; Fri, 25 Oct 2013 11:03:32 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Oct 2013 11:03:31 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id C6971C90026 for ; Fri, 25 Oct 2013 11:03:28 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22035.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9PF3Tgv53149702 for ; Fri, 25 Oct 2013 15:03:29 GMT Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r9PF3TiH027871 for ; Fri, 25 Oct 2013 11:03:29 -0400 Message-ID: <526A8840.5020303@linux.vnet.ibm.com> Date: Fri, 25 Oct 2013 11:03:28 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1382461164-8854-1-git-send-email-mrhines@linux.vnet.ibm.com> <5266DE16.8060508@redhat.com> <52676BF6.7010305@redhat.com> In-Reply-To: <52676BF6.7010305@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, quintela@redhat.com, chegu_vinod@hp.com, qemu-devel@nongnu.org, owasserm@redhat.com, onom@us.ibm.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com On 10/23/2013 02:25 AM, Paolo Bonzini wrote: > Il 22/10/2013 21:20, Eric Blake ha scritto: >>>> -# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is >>>> +# @rdma-pin-all: Controls whether or not the entire VM memory footprint is >>>> # mlock()'d on demand or all at once. Refer to docs/rdma.txt for usage. >>>> # Disabled by default. Experimental: may (or may not) be renamed after >>>> # further testing is complete. (since 1.6) >> I'd also recommend tweaking this to say 'since 1.7', since the spelling >> 'rdma-pin-all' is new to this release. > I would also leave this as experimental for now. > > Basically the point of the "experimental" designation was to ensure that > RDMA protocol changes might not preserve backwards compatibility. The > capability is a separate thing from the protocol, as it would likely > apply to any migration-over-RDMA implementation > > Paolo > Well, I tried posting libvirt support with this naming scheme, but they didn't accepted. Their reason (Daniel, I think) is valid: experimental implies that it shouldn't be exposed in the management software until it is deemed stable at some point. As far we can tell, it is stable, and made very clear using the new 'setup' state in the migration state machine. How would we expose it in libvirt as an experimental feature without labeling it as an experimental feature? - Michael