From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Va3xe-0004y3-Dw for qemu-devel@nongnu.org; Sat, 26 Oct 2013 09:31:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Va3xX-0006kS-KD for qemu-devel@nongnu.org; Sat, 26 Oct 2013 09:31:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Va3xX-0006jy-CX for qemu-devel@nongnu.org; Sat, 26 Oct 2013 09:31:19 -0400 Message-ID: <526BC420.80907@redhat.com> Date: Sat, 26 Oct 2013 15:31:12 +0200 From: Max Reitz MIME-Version: 1.0 References: <1382660107-26518-1-git-send-email-thibaut.laurent@gmail.com> In-Reply-To: <1382660107-26518-1-git-send-email-thibaut.laurent@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thibaut LAURENT , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Am 25.10.2013 02:15, schrieb Thibaut LAURENT: > Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c, > bdrv_open_common will throw an error when trying to open a file > read-only with the BDRV_O_COPY_ON_READ flag set. > Although BDRV_O_RDWR is unset for the backing files, > BDRV_O_COPY_ON_READ is still passed on if copy-on-read was requested > for the drive. Let's unset this flag too before opening the backing > file, or bdrv_open_common will fail. > > Signed-off-by: Thibaut LAURENT > --- > block.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz