From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
lcapitulino@redhat.com, stefanha@redhat.com,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT
Date: Mon, 28 Oct 2013 11:44:01 +0100 [thread overview]
Message-ID: <526E3FF1.7060305@redhat.com> (raw)
In-Reply-To: <5265917D.3000903@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 21/10/2013 22:41, Eric Blake ha scritto:
> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>> The define will be moved to qapi-schema.json later, so rename
>> the prefix to match its naming style.
>
> Wouldn't it be simpler to fix the code generator to special case
> QEvent to turn into QEVENT, instead of having to go through this
> churn? But if we _like_ the Q_EVENT_ prefix, then this looks
> fairly mechanical:
No, I disagree. However, since something _is_ being renamed, we might
as well rename every QEVENT_ to MONITOR_EVENT_ and avoid patch 2.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSbj/xAAoJEBvWZb6bTYbyNkQP/R0l+qwakF5zBfwoiEc7Ru4r
YnG6B2HkCn7Bc5juDnZXYIvPdX1+n3x9tvGTcw2eP+8hiUQBmVGQEWNIlvOkPQoW
EtW7wzf0uRvROeYy0aqr5P+xU/0uDLonr3wONxv3aMc99CwZvJ918X889is5z4ps
P7CrMrnh9Ng99SgmkFgYS9KxwM004iIKyGyjKbYC+BYTKrJd7chzGfb41r687AbR
7CMb3gBCUvFRU2E2+yCdRI/cRVgRDSCMZ4Ic5VNK4DFKa6eq+yzP4zEhILkStl1o
yvPYlxpfHNLLle83iOb4rJFmBYz6mrAkVhfUOXdrKPegU6l+hod0vpuXcm3tMIO8
YJ9iMxeFrI2tFsIXVzQgugz4jaSY0BDapCP15aL9zqIzACiTpYZeaVden/gWu1Oy
iupuue9xzT2l40FCQwNXrGULOiOVRuiry8JstJ0A/valQi/xRy28cky+FI+PglNt
3eaj3GYK0oF1UyG3e22cFensIUOTWE1Znbm7/5ON12xcFOTE1e5bzvuPWUDOJ1wh
2I/p7Bn7uewQLstL14++gN1iMP+GCXJ0ce7xc0QtTP7jvtYCeTt+yBDC7jlan4Zb
N/CEISOti9obFYlDKiQL+Hdk4ivQsFjT2B1p7feGSd5JAZtLthNxBOSQrS4wg5fd
WW6UX7otKyj6MADQl3Jk
=Q+3Z
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-10-28 10:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 2:15 [Qemu-devel] [PATCH 0/6] qapi: generate event defines automatically Wenchao Xia
2013-10-21 2:16 ` [Qemu-devel] [PATCH 1/6] block: use type MonitorEvent directly Wenchao Xia
2013-10-21 2:16 ` [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent Wenchao Xia
2013-10-21 20:38 ` Eric Blake
2013-11-01 14:02 ` Luiz Capitulino
2013-11-01 14:21 ` [Qemu-devel] [libvirt] QEMU 1.6 and drive discard parameter Gareth Bult
2013-11-04 1:59 ` [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent Wenchao Xia
2013-11-04 13:33 ` Luiz Capitulino
2013-11-05 2:17 ` Wenchao Xia
2013-11-05 2:51 ` Luiz Capitulino
2013-11-05 5:31 ` Wenchao Xia
2013-11-05 14:06 ` Luiz Capitulino
2013-11-06 3:25 ` Wenchao Xia
2013-10-21 2:16 ` [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT Wenchao Xia
2013-10-21 20:41 ` Eric Blake
2013-10-22 2:43 ` Wenchao Xia
2013-10-28 10:44 ` Paolo Bonzini [this message]
2013-10-29 5:22 ` Wenchao Xia
2013-10-29 16:09 ` Eric Blake
2013-10-30 7:26 ` Wenchao Xia
2013-11-01 14:06 ` Luiz Capitulino
2013-10-29 18:18 ` Kevin Wolf
2013-10-30 7:27 ` Wenchao Xia
2013-10-30 11:55 ` Paolo Bonzini
2013-10-31 5:26 ` Wenchao Xia
2013-10-21 2:16 ` [Qemu-devel] [PATCH 4/6] qapi: move event defines to qapi-schema.json Wenchao Xia
2013-10-21 20:45 ` Eric Blake
2013-10-21 2:16 ` [Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[] Wenchao Xia
2013-10-21 20:47 ` Eric Blake
2013-10-21 2:16 ` [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent Wenchao Xia
2013-10-21 21:00 ` Eric Blake
2013-10-22 3:19 ` Wenchao Xia
2013-10-22 3:46 ` Eric Blake
2013-10-23 0:37 ` Wenchao Xia
2013-10-29 23:02 ` Eric Blake
2013-10-30 7:51 ` Wenchao Xia
2013-10-22 6:55 ` Wenchao Xia
2013-10-22 7:33 ` Wenchao Xia
2013-10-22 8:58 ` Eric Blake
2013-10-25 9:16 ` [Qemu-devel] [PATCH 0/6] qapi: generate event defines automatically Wenchao Xia
2013-11-01 14:28 ` Luiz Capitulino
2013-11-04 1:54 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E3FF1.7060305@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).