From: Stefan Weil <sw@weilnetz.de>
To: Jan Kiszka <jan.kiszka@web.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Fix compiler warning (-Werror=clobbered)
Date: Mon, 28 Oct 2013 20:18:53 +0100 [thread overview]
Message-ID: <526EB89D.4080508@weilnetz.de> (raw)
In-Reply-To: <52395AB5.60309@web.de>
Am 18.09.2013 09:48, schrieb Jan Kiszka:
> On 2013-09-18 09:26, Peter Maydell wrote:
[...]
>> And gcc's documentation of the 'noreturn' attribute specifically
>> says it does not affect the exceptional path where the function
>> returns via longjmp.
> OK, that is the clarifying bit of information.
>
> Now the question is if want to drop support for faulty compilers again,
> work around the false-positive warning, or avoid the issue differently
> than via reloading.
>
> Jan
Recently commit 6c78f29a2424622bfc9c30dfbbc13404481eacb6
added a third variable which is reloaded now. Obviously the clang
compiler needs this workaround.
Jan, can you remember whether the initial problems were also
caused by clang? If yes, we might restrict the code to that compiler.
This would avoid the -Wclobbered warnings with newer gcc while
still fixing the code generated by clang.
Stefan
next prev parent reply other threads:[~2013-10-28 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 17:03 [Qemu-devel] [PATCH] cpu-exec: Fix compiler warning (-Werror=clobbered) Stefan Weil
2013-09-17 17:17 ` Jan Kiszka
2013-09-17 17:27 ` Stefan Weil
2013-09-17 21:24 ` Peter Maydell
2013-09-18 7:06 ` Jan Kiszka
2013-09-18 7:26 ` Peter Maydell
2013-09-18 7:48 ` Jan Kiszka
2013-10-28 19:18 ` Stefan Weil [this message]
2013-10-29 8:07 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526EB89D.4080508@weilnetz.de \
--to=sw@weilnetz.de \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).