From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VasLL-0004Nx-9k
	for qemu-devel@nongnu.org; Mon, 28 Oct 2013 15:19:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VasLC-0007J4-Sf
	for qemu-devel@nongnu.org; Mon, 28 Oct 2013 15:19:15 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=50338
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1VasLC-0007It-Lq
	for qemu-devel@nongnu.org; Mon, 28 Oct 2013 15:19:06 -0400
Message-ID: <526EB89D.4080508@weilnetz.de>
Date: Mon, 28 Oct 2013 20:18:53 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1379437402-30804-1-git-send-email-sw@weilnetz.de>
	<CAFEAcA-GzhJUud44EC14zyi0JEwYAer-wHuE9SyE5rzubOUdMA@mail.gmail.com>
	<5239510D.9070608@web.de>
	<CAFEAcA-iaVkgohK3xKiVy_8_GtYTUizMXfAJr+c+PXUU1KPxgg@mail.gmail.com>
	<52395AB5.60309@web.de>
In-Reply-To: <52395AB5.60309@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Fix compiler warning
	(-Werror=clobbered)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

Am 18.09.2013 09:48, schrieb Jan Kiszka:
> On 2013-09-18 09:26, Peter Maydell wrote:
[...]
>> And gcc's documentation of the 'noreturn' attribute specifically
>> says it does not affect the exceptional path where the function
>> returns via longjmp.
> OK, that is the clarifying bit of information.
>
> Now the question is if want to drop support for faulty compilers again,
> work around the false-positive warning, or avoid the issue differently
> than via reloading.
>
> Jan

Recently commit 6c78f29a2424622bfc9c30dfbbc13404481eacb6
added a third variable which is reloaded now. Obviously the clang
compiler needs this workaround.

Jan, can you remember whether the initial problems were also
caused by clang? If yes, we might restrict the code to that compiler.
This would avoid the -Wclobbered warnings with newer gcc while
still fixing the code generated by clang.

Stefan