From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbC7w-0003EN-QQ for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:26:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbC7p-00007v-8G for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:26:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbC7o-00007l-UX for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:26:37 -0400 Message-ID: <526FE1B7.6010707@redhat.com> Date: Tue, 29 Oct 2013 10:26:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1383062897-30084-1-git-send-email-armbru@redhat.com> <1383062897-30084-8-git-send-email-armbru@redhat.com> In-Reply-To: <1383062897-30084-8-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TSOGOeBjmArM5W0qoTLQ8XH1VhNWFFKr9" Subject: Re: [Qemu-devel] [PATCH v2 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com, qemu-devel@nongnu.org Cc: kwolf@redhat.com, borntraeger@de.ibm.com, afaerber@suse.de, anthony@codemonkey.ws, peter.maydell@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TSOGOeBjmArM5W0qoTLQ8XH1VhNWFFKr9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/29/2013 10:08 AM, armbru@redhat.com wrote: > From: Markus Armbruster >=20 > A PIIX3/PIIX4 southbridge has multiple functions. We model each > function as a separate qdev. Two of them need some special wiring set > up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01.0, > and the SMBus controller at 01.3. >=20 > The IDE controller at 01.1 (piix3-ide, piix3-ide-xen, piix4-ide) has > always had cannot_instantiate_with_device_add_yet set, but there is no > obvious reason why device_add could not work for them. Drop it. > +++ b/hw/acpi/piix4.c > @@ -508,9 +508,14 @@ static void piix4_pm_class_init(ObjectClass *klass= , void *data) > k->revision =3D 0x03; > k->class_id =3D PCI_CLASS_BRIDGE_OTHER; > dc->desc =3D "PM"; > - dc->cannot_instantiate_with_device_add_yet =3D true; /* FIXME expl= ain why */ > + dc->cannot_instantiate_with_device_add_yet =3D true; > dc->vmsd =3D &vmstate_acpi; > dc->props =3D piix4_pm_properties; > + /* > + * Reason: part of PIIX4 southbridge, needs to be wired up, > + * e.g. by mips_malta_init() > + */ > + dc->cannot_instantiate_with_device_add_yet =3D true; Is it intentional that you initialize the field twice to the same value? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TSOGOeBjmArM5W0qoTLQ8XH1VhNWFFKr9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSb+G3AAoJEKeha0olJ0NqS2gH+wWSAgfNS1X8vNzb+s/RpO37 A6E/G+vgmTHZ7x8zR5OmoJr7M8JuQHa+hnuxfZqxYLEAw6rCnHkWVNr5OcG4yVmq gorlpgubrDkQLoe4YnxQBinVxEom7VsblsFZaQ/kzhH+fAZdrFLOfvMw1NLgGVTG V45ouvReOIzflyMLA8xx0ZUDaT5On3ah2+eTpi/HywEzwxx0KgSq9/+AUTMvaVFU i7w7yGU5URrkfnnb/CefxGLWxdxQ52j3RSWKr92oaBeYKWbLv2PoR86LfCsErf+T mTUT2gkgN3UhhsQmnNF3YSodncd4UcRrgRCjAWEp4hQ5gPQszHnyc6PrK65C0BM= =k7cG -----END PGP SIGNATURE----- --TSOGOeBjmArM5W0qoTLQ8XH1VhNWFFKr9--