From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56469)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VbCN1-0001xJ-05
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:42:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VbCMv-0005a0-1C
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:42:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1VbCMu-0005Zs-Q0
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:42:12 -0400
Message-ID: <526FE559.2000201@redhat.com>
Date: Tue, 29 Oct 2013 17:42:01 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1380717564-11098-1-git-send-email-benoit@irqsave.net>
	<1380717564-11098-7-git-send-email-benoit@irqsave.net>
	<524ED52C.7010207@redhat.com> <20131028123119.GB2890@irqsave.net>
In-Reply-To: <20131028123119.GB2890@irqsave.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Beno=EEt_Canet?= <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Am 28.10.2013 13:31, schrieb Beno=EEt Canet:
> Le Friday 04 Oct 2013 =E0 16:48:12 (+0200), Max Reitz a =E9crit :
>> On 2013-10-02 14:39, Beno=EEt Canet wrote:
>>> Use gnutls's SHA-256 to compare versions.
>> Wouldn't CRC32 suffice? (I don't really oppose using SHA, but taking
>> in gnutls as a dependency just for comparing several memory areas
>> seems a bit much to me)
> Initially it gzip's addler32 was used but someone was concerned with th=
e risk
> of collisions.
> Anyway the code fallback using hashes only when something wrong is dete=
cted so
> it won't impact the normal case.
>
> Best regards
>
> Beno=EEt

Yes, that's correct, but it adds a new dependency to qemu. Personally, I
am unable to decide whether this is better than having a higher risk of
collisions with CRC, so I'll leave the decision to someone more
qualified (like you). ;-)

Max