From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VbCxq-00070o-OD
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 13:20:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VbCxk-0002Mq-Tw
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 13:20:22 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <526FEE4B.7020801@twiddle.net>
Date: Tue, 29 Oct 2013 10:20:11 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <526FB1A7.5090109@gmail.com>
In-Reply-To: <526FB1A7.5090109@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 00/19] PowerPC VSX Stage 3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 10/29/2013 06:01 AM, Tom Musta wrote:
> V2: Implemented changes based on feedback from Richard Henderson and
> Peter Maydell:
>     - Included float64_to_uint64() patch in this series rather than just
>       cite it as a pre-requesite.
>     - Isolated float32_to_uint64() in its own patch.
>     - Re-implemented helpers and eliminated the need for some of the proposed
>       softfloat routines (float*_is_denormal, float*_get_unbiased_exp).
>     - Re-implemented severy helpers so that corner cases (e.g. invalid
>       operations) are detected by softfloat.
>     - Re-implemented fused multiply-add to use the softfloat muladd routines.
>     - Re-implemented the min/max instructions to used the softfloat
>       min/max functions.
>     - assorted style fixes
> 
> Tom Musta (19):
>   Fix float64_to_uint64
>   Add float32_to_uint64()
>   Add set_fprf Argument to fload_invalid_op_excp()
>   General Support for VSX Helpers
>   Add VSX ISA2.06 xadd/xsub Instructions
>   Add VSX ISA2.06 xmul Instructions
>   Add VSX ISA2.06 xdiv Instructions
>   Add VSX ISA2.06 xre Instructions
>   Add VSX ISA2.06 xsqrt Instructions
>   Add VSX ISA2.06 xrsqrte Instructions
>   Add VSX ISA2.06 xtdiv Instructions
>   Add VSX ISA2.06 xtsqrt Instructions
>   Add VSX ISA2.06 Multiply Add Instructions
>   Add VSX xscmp*dp Instructions
>   Add VSX xmax/xmin Instructions
>   Add VSX Vector Compare Instructions
>   Add VSX Floating Point to Floating Point Conversion Instructions
>   Add VSX ISA2.06 Integer Conversion Instructions
>   Add VSX Rounding Instructions

Reviewed-by: Richard Henderson <rth@twiddle.net>

Looks good.


r~