From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbDX7-0005ek-Mo for qemu-devel@nongnu.org; Tue, 29 Oct 2013 13:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbDX1-0006I9-MA for qemu-devel@nongnu.org; Tue, 29 Oct 2013 13:56:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbDX1-0006I3-DD for qemu-devel@nongnu.org; Tue, 29 Oct 2013 13:56:43 -0400 Message-ID: <526FF6D2.60004@redhat.com> Date: Tue, 29 Oct 2013 18:56:34 +0100 From: Max Reitz MIME-Version: 1.0 References: <1380717564-11098-1-git-send-email-benoit@irqsave.net> <524ED15C.2010005@redhat.com> <20131029075929.GC2873@irqsave.net> <526FF67F.2070601@redhat.com> In-Reply-To: <526FF67F.2070601@redhat.com> Content-Type: multipart/mixed; boundary="------------040804020706030405040204" Subject: Re: [Qemu-devel] [PATCH V9 00/11] Quorum block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is a multi-part message in MIME format. --------------040804020706030405040204 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id r9THuejb026058 Am 29.10.2013 18:55, schrieb Max Reitz: > Am 29.10.2013 08:59, schrieb Beno=EEt Canet: >> Le Friday 04 Oct 2013 =E0 16:31:56 (+0200), Max Reitz a =E9crit : >>> On 2013-10-02 14:39, Beno=EEt Canet wrote: >>>> It must be applied on top of "block: Add BlockDriver.bdrv_check_ext_= snapshot." >>>> >>>> This patchset create a block driver implementing a quorum using tota= l qemu disk >>>> images. Writes are mirrored on the $total files. >>>> For the reading part the $total files are read at the same time and = a vote is >>>> done to determine if a qiov version is present $threshold or more ti= mes. It then >>>> return this majority version to the upper layers. >>>> When i < $threshold versions of the data are returned by the lower l= ayer the >>>> quorum is broken and the read return -EIO. >>>> >>>> The goal of this patchset is to be turned in a QEMU block filter liv= ing just >>>> above raw-*.c and below qcow2/qed when the required infrastructure w= ill be done. >>>> >>>> Main use of this feature will be people using NFS appliances which c= an be >>>> subjected to bitflip errors. >>>> >>>> This patchset can be used to replace blkverify and the out of tree b= lkmirror. >>>> >>>> v9: integrate latests comments from kevin >>>> >>>> Beno=EEt Canet (11): >>>> quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. >>>> quorum: Create BDRVQuorumState and BlkDriver and do init. >>>> quorum: Add quorum_aio_writev and its dependencies. >>>> blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() fro= m >>>> blkverify. >>>> quorum: Add quorum_aio_readv. >>>> quorum: Add quorum mechanism. >>>> quorum: Add quorum_getlength(). >>>> quorum: Add quorum_invalidate_cache(). >>>> quorum: Add quorum_co_get_block_status. >>>> quorum: Add quorum_co_flush(). >>>> quorum: Add quorum_open() and quorum_close(). >>>> >>>> block/Makefile.objs | 1 + >>>> block/blkverify.c | 108 +---- >>>> block/quorum.c | 1035 ++++++++++++++++++++++++++++++++++= +++++++++++ >>>> configure | 36 ++ >>>> include/monitor/monitor.h | 2 + >>>> include/qemu-common.h | 2 + >>>> monitor.c | 2 + >>>> util/iov.c | 103 +++++ >>>> 8 files changed, 1183 insertions(+), 106 deletions(-) >>>> create mode 100644 block/quorum.c >>>> >>> Could you add a qemu-iotest if possible? >> I don't see how to specify quorum to qemu-io for bytes checking. >> >> Best regards >> >> Beno=EEt > As of commit b543c5cd, you can pass options to the block driver through > qemu-io -c open. The problem for quorum is that it cannot handle the > filename option (which qemu-io will always set). I've attached a diff t= o > change this behavior (which makes the path parameter for open optional > and passes NULL to bdrv_open if it is not given). You're free to make > use of it. ;-) > > If this diff is applied, you can invoke qemu-io with quorum for example > as following: > qemu-io -c 'open -o > file.driver=3Dquorum,file.children.0.file.filename=3D[Image > 1],file.children.1.file.filename=3D[Image 2],file.vote_threshold=3D[x]' > > Max Obviously forgot to attach the diff. Max --------------040804020706030405040204 Content-Type: text/plain; charset=UTF-8; name="qemu-io-open.diff" Content-Disposition: attachment; filename="qemu-io-open.diff" Content-Transfer-Encoding: 7bit diff --git a/qemu-io.c b/qemu-io.c index 3b3340a..4d0e9f6 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -57,8 +57,13 @@ static int openfile(char *name, int flags, int growable, QDict *opts) if (growable) { if (bdrv_file_open(&qemuio_bs, name, opts, flags, &local_err)) { - fprintf(stderr, "%s: can't open device %s: %s\n", progname, name, - error_get_pretty(local_err)); + if (name) { + fprintf(stderr, "%s: can't open device %s: %s\n", progname, + name, error_get_pretty(local_err)); + } else { + fprintf(stderr, "%s: can't open device: %s\n", progname, + error_get_pretty(local_err)); + } error_free(local_err); return 1; } @@ -66,8 +71,13 @@ static int openfile(char *name, int flags, int growable, QDict *opts) qemuio_bs = bdrv_new("hda"); if (bdrv_open(qemuio_bs, name, opts, flags, NULL, &local_err) < 0) { - fprintf(stderr, "%s: can't open device %s: %s\n", progname, name, - error_get_pretty(local_err)); + if (name) { + fprintf(stderr, "%s: can't open device %s: %s\n", progname, + name, error_get_pretty(local_err)); + } else { + fprintf(stderr, "%s: can't open device: %s\n", progname, + error_get_pretty(local_err)); + } error_free(local_err); bdrv_unref(qemuio_bs); qemuio_bs = NULL; @@ -127,6 +137,7 @@ static int open_f(BlockDriverState *bs, int argc, char **argv) int c; QemuOpts *qopts; QDict *opts = NULL; + char *filename = NULL; while ((c = getopt(argc, argv, "snrgo:")) != EOF) { switch (c) { @@ -160,11 +171,13 @@ static int open_f(BlockDriverState *bs, int argc, char **argv) flags |= BDRV_O_RDWR; } - if (optind != argc - 1) { + if (optind == argc - 1) { + filename = argv[optind]; + } else if (optind < argc - 1) { return qemuio_command_usage(&open_cmd); } - return openfile(argv[optind], flags, growable, opts); + return openfile(filename, flags, growable, opts); } static int quit_f(BlockDriverState *bs, int argc, char **argv) --------------040804020706030405040204--